Bug #39052
Send sane HTTP response in showpic on error
| Status: | Closed | Start date: | 2012-07-18 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assignee: | - | % Done: | 100% |
|
| Category: | Frontend | |||
| Target version: | 4.5.18 | |||
| TYPO3 Version: | 6.0 | Complexity: | easy | |
| PHP Version: | 5.3 | |||
| Votes: | 1 (View) |
Description
Currently, if showpic.php requests fail, exceptions are thrown. Those are
usually converted to a HTTP response 500 (internal server error) by the
production exception handler. Crawlers react on 500 by trying to index
the resource again later.
This is changed to now set specific response codes. If the paramters are
incorrect or broken, an 410 (Gone) will be sent, informing users and
crawlers that the resource is not available under this URL. Crawlers
like googleBot will then stop requesting the resource.
In case all parameters are ok, but the image itself is not found, a 404
will be sent to the client. Crawlers will try to index the resource
again only if there are still links pointing to the resource.
Related issues
| related to Core - Bug #24453: showpic.php causes a fatal error if parameters GET variab... | Closed | 2011-01-02 | ||
| related to Core - Bug #26893: BE Log is flooded with "Parameter Error: No file or no pa... | Resolved | 2011-05-18 | ||
| related to Core - Bug #38896: Core: Exception handler (WEB) and Showpic.php | New | 2012-07-12 |
Associated revisions
[BUGFIX] Send sane HTTP response in showpic on error
Currently, if showpic.php requests fail, exceptions are thrown. Those are
usually converted to a HTTP response 500 (internal server error) by the
production exception handler. Crawlers react on 500 by trying to index
the resource again later.
This is changed to now set specific response codes. If the paramters are
incorrect or broken, an 410 (Gone) will be sent, informing users and
crawlers that the resource is not available under this URL. Crawlers
like googleBot will then stop requesting the resource.
In case all parameters are ok, but the image itself is not found, a 404
will be sent to the client. Crawlers will try to index the resource
again only if there are still links pointing to the resource.
Change-Id: I606937fa9953b88be5edf940201e0153223ae0e6
Fixes: #39052
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/12867
Reviewed-by: Mario Rimann
Reviewed-by: Ernesto Baschny
Tested-by: Anja Leichsenring
Reviewed-by: Anja Leichsenring
Reviewed-by: Marcus Krause
Tested-by: Marcus Krause
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
[BUGFIX] Send sane HTTP response in showpic on error
Currently, if showpic.php requests fail, exceptions are thrown. Those are
usually converted to a HTTP response 500 (internal server error) by the
production exception handler. Crawlers react on 500 by trying to index
the resource again later.
This is changed to now set specific response codes. If the paramters are
incorrect or broken, an 410 (Gone) will be sent, informing users and
crawlers that the resource is not available under this URL. Crawlers
like googleBot will then stop requesting the resource.
In case all parameters are ok, but the image itself is not found, a 404
will be sent to the client. Crawlers will try to index the resource
again only if there are still links pointing to the resource.
Change-Id: I606937fa9953b88be5edf940201e0153223ae0e6
Fixes: #39052
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/12915
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
[BUGFIX] Send sane HTTP response in showpic on error
Currently, if showpic.php requests fail, exceptions are thrown. Those are
usually converted to a HTTP response 500 (internal server error) by the
production exception handler. Crawlers react on 500 by trying to index
the resource again later.
This is changed to now set specific response codes. If the paramters are
incorrect or broken, an 410 (Gone) will be sent, informing users and
crawlers that the resource is not available under this URL. Crawlers
like googleBot will then stop requesting the resource.
In case all parameters are ok, but the image itself is not found, a 404
will be sent to the client. Crawlers will try to index the resource
again only if there are still links pointing to the resource.
Change-Id: I606937fa9953b88be5edf940201e0153223ae0e6
Fixes: #39052
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/12917
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
[BUGFIX] Send sane HTTP response in showpic on error
Currently, if showpic.php requests fail, exceptions are thrown. Those are
usually converted to a HTTP response 500 (internal server error) by the
production exception handler. Crawlers react on 500 by trying to index
the resource again later.
This is changed to now set specific response codes. If the paramters are
incorrect or broken, an 410 (Gone) will be sent, informing users and
crawlers that the resource is not available under this URL. Crawlers
like googleBot will then stop requesting the resource.
In case all parameters are ok, but the image itself is not found, a 404
will be sent to the client. Crawlers will try to index the resource
again only if there are still links pointing to the resource.
Change-Id: I606937fa9953b88be5edf940201e0153223ae0e6
Fixes: #39052
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/12919
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
[BUGFIX] Send sane HTTP response in showpic on error
Currently, if showpic.php requests fail, exceptions are thrown. Those are
usually converted to a HTTP response 500 (internal server error) by the
production exception handler. Crawlers react on 500 by trying to index
the resource again later.
This is changed to now set specific response codes. If the paramters are
incorrect or broken, an 410 (Gone) will be sent, informing users and
crawlers that the resource is not available under this URL. Crawlers
like googleBot will then stop requesting the resource.
In case all parameters are ok, but the image itself is not found, a 404
will be sent to the client. Crawlers will try to index the resource
again only if there are still links pointing to the resource.
Change-Id: I606937fa9953b88be5edf940201e0153223ae0e6
Fixes: #39052
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/12867
Reviewed-by: Mario Rimann
Reviewed-by: Ernesto Baschny
Tested-by: Anja Leichsenring
Reviewed-by: Anja Leichsenring
Reviewed-by: Marcus Krause
Tested-by: Marcus Krause
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
History
Updated by Gerrit Code Review 10 months ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12867
Updated by Christian Kuhn 10 months ago
Example:
http://www.domain.foo/?eID=tx_cms_showpic&file=uploads%2Ftx_foo%2Faoeu.jpg&md5=7ec23ea567813281234569acb0e24347adfb8645¶meters0=YoeuntzOjU6IndpZHRoIjtzOjQ6Ijc3MG0iO3M6NzoiYm9keVRhZyI7czo2ODoi¶meters1=PGJvZHkgbGVmdG1hcmdpbj0iMCIgdG9wbWFyZ2lIwIiBtYXJnaW53aWR0aD0i¶meters2=MCIgbWFyZ2luaGVpZ2h0PSIwIj4iO3M6NDoid3I7czozNToiPGEgaHJlZj0i¶meters3=amF2YXNjcmlwjbG9zZSgpOyI%2BfDwvYT4iO30%3D
Will result in a 410 after the patch, and was an exception before.
Updated by Gerrit Code Review 10 months ago
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/12915
Updated by Gerrit Code Review 10 months ago
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/12917
Updated by Gerrit Code Review 10 months ago
Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/12919
Updated by Christian Kuhn 10 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 0f83ce445cade0d3ec7b8c74f1282775769ffa65.
Updated by Gerrit Code Review 10 months ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/13198
Updated by Christian Kuhn 10 months ago
- Status changed from Under Review to Resolved
Applied in changeset d85d3b6fa9c142665a4703c883bfe14a8b16ecc8.
Updated by Gerrit Code Review 10 months ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/13305
Updated by Wouter Wolters 8 months ago
Please close this issue. All affected branches are up to date.
Updated by Stefan Galinski 8 months ago
- Status changed from Under Review to Closed