Project

General

Profile

Actions

Bug #39085

closed

fetchTask: Missing validation of SQL result

Added by Julian Hofmann almost 12 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
scheduler
Target version:
Start date:
2012-07-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The method fetchTask trys to fetch any tasks from table tx_scheduler_task by using exec_SELECT_queryArray (-> exec_SELECTquery -> mysql_query). The result is a resource on success, or FALSE on error. In the following the result is always expected as resource - the case of an error is not handled.
E.g. in case of an damaged table tx_scheduler_task the scheduler is trying to handle FALSE as resource and throws many exceptions.

In my opinion there should be a validation of the result and a locking in case of erros.


Related issues 1 (0 open1 closed)

Precedes TYPO3 Core - Bug #67463: Scheduler sometimes uses 100% CPU for daysClosedMathias Schreiber2015-06-15

Actions
Actions #1

Updated by Michael Stucki over 10 years ago

  • Category set to scheduler
Actions #2

Updated by Michael Stucki over 10 years ago

  • Project changed from 739 to TYPO3 Core
  • Category changed from scheduler to scheduler
Actions #3

Updated by Gerrit Code Review over 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36208

Actions #4

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36208

Actions #5

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36261

Actions #6

Updated by Mathias Schreiber over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF