Bug #39785: FAL: Various bugs when creating the local storage - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #39785

closed

FAL: Various bugs when creating the local storage

Added by Steffen Gebert over 11 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

File Abstraction Layer (FAL)

Target version:

Start date:

2012-08-13

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.0

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

t3lib_file_repository_storagerepository::findAll() contains this code:

        if (count($storageObjects) === 0) {
            $this->createLocalStorage(
                'fileadmin/ (auto-created)',
                $GLOBALS['TYPO3_CONF_VARS']['BE']['fileadminDir'],
                'relative',
                'This is the local fileadmin/ directory. This storage mount has been created automatically by TYPO3.'
            );
            $storageObjects = self::findAll();
        }

In the unit test createNewFileInLocalStorage this ends up in an endless loop.

Actions

Copy link

Updated by Benni Mack over 11 years ago

Subject changed from Endless loop in t3lib_file_repository_storagerepository to FAL: Various bugs when creating the local storage

Thanks for the hint. This brought me to think about the "auto-creation" mechanism for this. We only should execute this call if there has never been records in this table before. Sometimes, (because of the enable fields) there are no results as well. Thus the check is put BEFORE the SQL call and only executed once. No loop.

I also renamed the issue to reflect the changes.

Thus: * No loops anymore * Never auto-create an automount just because there are no other records.

Actions

Copy link