Bug #42051
closed
Javascript labels are not escaped, resulting in a bug when previewing with a french BE
100%
Description
Hi,
This bug was first posted here: http://lists.typo3.org/pipermail/typo3-english/2012-March/079796.html
I have got the same on a 4.5.19.
In function indexAction(), in typo3/sysext/workspaces/classes/controller/PreviewController.php, labels are not escaped for 'visualPreview' .... 'modeHbox'.
Particularly, in french, the label for "workspacePreviewDetail" contains a single quote, resulting in a javascript bug.
These labels should go through addInlineLanguageLabel or equivalent from the class t3lib_pageRenderer.
I will try to submit a patch later.
Updated by Fronzes Philippe over 11 years ago
I think this is the same issue than http://forge.typo3.org/issues/39339#note-5
Updated by Francois Suter over 11 years ago
It's the same issue indeed. I just stumbled on it too. I have a patch nearly ready for master.
Updated by Gerrit Code Review over 11 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15740
Updated by Gerrit Code Review over 11 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15740
Updated by Gerrit Code Review over 11 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15740
Updated by Gerrit Code Review over 11 years ago
Patch set 1 for branch workspaces_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/15758
Updated by Francois Suter over 11 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset commit:6ca05a7d92c028d415cf880ab5c83a2e6eeaa9f3.
Updated by Gerrit Code Review over 11 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch 4.6 has been pushed to the review server.
It is available at http://review.typo3.org/15762
Updated by Gerrit Code Review over 11 years ago
Patch set 1 for branch 4.5 has been pushed to the review server.
It is available at http://review.typo3.org/15763
Updated by Francois Suter over 11 years ago
- Status changed from Under Review to Resolved
Applied in changeset commit:a620e779d1ddd7ac2bb8fcf0b9ad0aa2b109be0a.
Updated by Michael Stucki over 10 years ago
- Category changed from Bugs to Workspaces
Updated by Michael Stucki over 10 years ago
- Project changed from 624 to TYPO3 Core
- Category changed from Workspaces to Workspaces
Updated by