Project

General

Profile

Actions
Copy link

Bug #54021

closed

Cleanup convertParameterReflectionToArray()

Added by Michiel Roos over 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Performance
Target version:
next-patchlevel
Start date:
2013-11-27
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:

Description

ReflectionService::convertParameterReflectionToArray() builds an array like so:

$parameterInformation = array(
            'position' => $parameterPosition,
            'byReference' => $parameter->isPassedByReference() ? TRUE : FALSE,
            'array' => $parameter->isArray() ? TRUE : FALSE,
            'optional' => $parameter->isOptional() ? TRUE : FALSE,
            'allowsNull' => $parameter->allowsNull() ? TRUE : FALSE
        );

The functions all return Boolean values and do not need to be tested for boaleanness again:

$parameterInformation = array(
            'position' => $parameterPosition,
            'byReference' => $parameter->isPassedByReference(),
            'array' => $parameter->isArray(),
            'optional' => $parameter->isOptional(),
            'allowsNull' => $parameter->allowsNull()
        );
Actions
Copy link

Also available in: Atom PDF