Project

General

Profile

Actions

Bug #64534

closed

useCombination: does not support foreign_types

Added by Andreas Allacher about 9 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
-
Start date:
2015-01-27
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

It is currently not possible to use foreign_types in combination with useCombination.
It might be enough to have this option available in the "MM" table and not in the one where useCombination is set, where it is currently ignored.

Though in the best case this might even be set in the table where I set useCombination.


Files

Wrong fields display.png (26.6 KB) Wrong fields display.png All fields displayed despite warning message Andreas Allacher, 2015-01-30 13:26
correct.png (125 KB) correct.png use of foreign_types_combination Andreas Allacher, 2015-01-30 13:26
correct2.png (122 KB) correct2.png use of foreign_types in table of main child record without foreign_types_combination Andreas Allacher, 2015-01-30 13:26
demoinline.zip (8.36 KB) demoinline.zip Andreas Allacher, 2015-01-30 13:26

Related issues 1 (1 open0 closed)

Related to TYPO3 Core - Bug #81176: IRRE + useCombination: overrideChildTca not working for ChildChildNew2017-05-10

Actions
Actions #1

Updated by Andreas Allacher about 9 years ago

To clarify:
I mean the appearance setting useCombination for an inline field in TCA configuration / backend editing.
Then the foreign_selector field will be combined to the inline rendering, instead of a select.
This works but I cannot pass foreign_types to the foreign_selector field that way. So I have to use the default showitem which might not be applicable in this scenario.

Actions #2

Updated by Andreas Allacher about 9 years ago

Bascially the issue is in
\TYPO3\CMS\Backend\Form\Element\InlineElement::renderCombinationTable method:

Inside I have the following call:

$this->renderMainFields($comboConfig['foreign_table'], $comboRecord);

That mean the TCA setting 'foreign_types' is not passed on to the renderMainFields method.

There are two possibilities pass on the 'foreign_types' setting of the childrecord's foreign_selector field.
Or to pass on a foreign_types_combination setting from the field where I set useCombination.

I will provide an example/code change later.

Actions #3

Updated by Gerrit Code Review about 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36414

Updated by Andreas Allacher about 9 years ago

Added Demo EXT, possible commit that includes support for both options and screenshots.

Actions #5

Updated by Gerrit Code Review about 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36414

Actions #6

Updated by Gerrit Code Review about 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36414

Actions #7

Updated by Morton Jonuschat over 8 years ago

  • Status changed from Under Review to New

Patchset abandonded due to FormEngine rewrite.

Actions #8

Updated by Christian Eßl over 4 years ago

  • Category set to FormEngine aka TCEforms
Actions #9

Updated by Susanne Moog about 4 years ago

  • Status changed from New to Needs Feedback

Can somebody check whether this is still an issue since the formengine rewrite?

Actions #10

Updated by Ralf Hettinger over 2 years ago

  • Related to Bug #81176: IRRE + useCombination: overrideChildTca not working for ChildChild added
Actions #11

Updated by Ralf Hettinger over 2 years ago

As far as I understand, #81176 is the descendant to this one after the formengine rewrite...

Actions #12

Updated by Christian Kuhn over 2 years ago

  • Status changed from Needs Feedback to Closed

Closing in favor of #81176

Actions

Also available in: Atom PDF