Project

General

Profile

Actions

Bug #67415

closed

bug with clicmenu when choosing witch option to display

Added by Christophe Monard almost 9 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend API
Target version:
Start date:
2015-06-11
Due date:
% Done:

100%

Estimated time:
1.00 h
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:
Remote Sprint

Description

When you personnalise the clickmenu items, you cannot use following options : moreoptions, hide, edit_access, edit_pageproperties.

In 6.2: the extra_page_cm_options extension is buggy
In 7 : the extra_page_cm_options get merged by copy paste, so bug is still present.

the array_splice didn't preseve array keys.

It's easy to fix. I'll try to provide a fix soon

here's the fix for 6.2 : line 106
replace :
array_splice($menuItems, $c, 0, $localItems);

by
$first = array_slice($menuItems, 0, $c, TRUE);
$last = array_slice($menuItems, $c, NULL, TRUE);
$menuItems = array_merge($first, $localItems, $last);

In 7, it need to be fixed same way, but the code can be cleaned and get rewrited to use same writing style than the rest of the extension and optimise the process.

Actions #1

Updated by Wouter Wolters almost 9 years ago

Can you come up with a patch?

Help instructions can be found at http://wiki.typo3.org/CWT

Actions #2

Updated by Benni Mack almost 9 years ago

  • Target version changed from next-patchlevel to 7.4 (Backend)
  • Sprint Focus set to On Location Sprint
Actions #3

Updated by Susanne Moog almost 9 years ago

  • Target version changed from 7.4 (Backend) to 7.5
Actions #4

Updated by Anja Leichsenring almost 9 years ago

  • Sprint Focus changed from On Location Sprint to Remote Sprint
Actions #5

Updated by Benni Mack over 8 years ago

  • Target version changed from 7.5 to 7 LTS
Actions #6

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43880

Actions #7

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43880

Actions #8

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43880

Actions #9

Updated by Benni Mack over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #10

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF