Project

General

Profile

Actions

Bug #69291

closed

Fix configuration for backend module icons

Added by Helmut Hummel over 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend API
Target version:
-
Start date:
2015-08-24
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

http://review.typo3.org/38004 removed the typo3/mod directory
with the main modules and their configuration and added the configuration
to `$GLOBALS['TBE_MODULES']`directly.
However for that a sub array key `configuration` was used,
which is inconsistent with all our current API and its usages
across other modules, leading to the situation that
this configuration was basically ignored.

On top of that, http://review.typo3.org/39316 introduced the possibility
to use sprite icons as module icons, which used the configuration
key `icon` in the above mentioned sub array key `configuration`,
making this key the only option evaluated in the sub array.

This change removes this sub array and moves the sprite icon configuration
on top for consistency. For that the key must be changed
to 'sprite-icon' as 'icon' was already taken for
Extbase module icon configuration.


Related issues 3 (0 open3 closed)

Related to TYPO3 Core - Feature #66822: Allow module menu items to use sprite iconsClosedBenni Mack2015-05-07

Actions
Related to TYPO3 Core - Task #65900: Remove directory typo3/mod/ClosedBenni Mack2015-03-22

Actions
Related to TYPO3 Core - Bug #69421: Remove top level modules from access checksClosed2015-08-31

Actions
Actions #1

Updated by Helmut Hummel over 8 years ago

  • Description updated (diff)
Actions #2

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42854

Actions #3

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42854

Actions #4

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42854

Actions #5

Updated by Gerrit Code Review over 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42854

Actions #6

Updated by Gerrit Code Review over 8 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42854

Actions #7

Updated by Helmut Hummel over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF