Bug #69327
closed
Check if absolute url is used for responsive images
0%
Description
Creating responsive images adds always absRefPrefix to the image url.
If you use FAL driver like aus_driver_local_cdn. There is an absolute url and prepending absRefPrefix will create a wrong file path.
I created a small patch which resolves this.
Files
Updated by Alexander Opitz over 8 years ago
- Status changed from New to Needs Feedback
Hi Heiko,
thanks for the patch, can you push the patch for master into Gerrit?
Updated by Heiko Kromm over 8 years ago
Hi Alexander,
I've never pushed something to gerrit before.
I followed this description: https://forge.typo3.org/projects/9/wiki/Working_with_Gerrit_as_a_Developer
Additionaly I added a ssh-Public-Key to my account on review.typo3.org, but I get a "Fatal: Could not read from remote repository." when I try to push with the following command:
git push ssh://review.typo3.org/Packages/TYPO3.CMS HEAD:refs/for/TYPO3_6-2
Do I need an additional authorization that allows me to push?
Connecting via ssh works.
Updated by Alexander Opitz over 8 years ago
Hi Heiko,
at first a patch should first only be done for master and if this is accepted and merged we will backport it to other versions (like 6.2) if it is a needed bugfix without to much intrusion.
So correctly you should checkout master, patch it and commit. Afterwards push it with
git push origin HEAD:refs/for/master
Updated by Gerrit Code Review over 8 years ago
- Status changed from Needs Feedback to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42992
Updated by Gerrit Code Review over 8 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42992
Updated by Gerrit Code Review over 8 years ago
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42993
Updated by Gerrit Code Review over 8 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42992
Updated by
Updated by Gerrit Code Review over 8 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42992
Updated by Alexander Opitz over 8 years ago
- Status changed from Under Review to Needs Feedback
Is this issue resolved with the patch of #69861 ?
Updated by Morton Jonuschat over 8 years ago
- Category set to Content Rendering
- Status changed from Needs Feedback to Resolved
Yes it is, just verified / backported
Updated by