Project

General

Profile

Actions

Task #79159

closed

Introduce abstract class to get rid of code duplication

Added by Mona Muzaffar over 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Code Cleanup
Target version:
Start date:
2017-01-04
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.1
Tags:
Complexity:
Sprint Focus:

Description

FormFlexAjaxController / FormInlineAjaxController (maybe also class FormSelectTreeAjaxController) contain identical code to merge requireJsModule into "scriptCall" result,
extract to some abstract class.
Move the code to some method, extend and use the method.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #84201: Protect forgotten AbstractFormEngineAjaxController methodClosed2018-03-11

Actions
Actions #1

Updated by Gerrit Code Review over 7 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51148

Actions #2

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51148

Actions #3

Updated by Gerrit Code Review over 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51148

Actions #4

Updated by Gerrit Code Review over 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51148

Actions #5

Updated by Gerrit Code Review over 7 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51148

Actions #6

Updated by Gerrit Code Review over 7 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51148

Actions #7

Updated by Gerrit Code Review over 7 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51148

Actions #8

Updated by Mona Muzaffar over 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions #10

Updated by Christian Kuhn about 6 years ago

  • Related to Bug #84201: Protect forgotten AbstractFormEngineAjaxController method added
Actions

Also available in: Atom PDF