Project

General

Profile

Actions
Copy link

Bug #80899

open

Epic #65815: Improve Indexed search indexer

indexed_search can't extract metadata

Added by Christian Toffolo about 7 years ago. Updated over 1 year ago.

Status:
Needs Feedback
Priority:
Should have
Assignee:
-
Category:
Indexed Search
Target version:
Candidate for patchlevel
Start date:
2017-04-19
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.1
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

indexed_search, in method 

\TYPO3\CMS\IndexedSearch\Indexer::splitHTMLContent
tries to extract metadata while indexing but can't because the html content at that point has markers like 
<!-- ###META79deef79d064c0ac810f34ff70431fb0### -->

Actions
Copy link
 #1

Updated by Benni Mack almost 7 years ago

  • Target version changed from 8 LTS to next-patchlevel
Actions
Copy link
 #2

Updated by Benni Mack about 5 years ago

  • Target version changed from next-patchlevel to Candidate for patchlevel
Actions
Copy link
 #3

Updated by Markus Mächler almost 4 years ago

We worked around this bug using the following XClass:

Indexer.php

<?php
namespace Vendor\YourExt;

class Indexer extends \TYPO3\CMS\IndexedSearch\Indexer 
{
    /**
     * Workaround the following bug: https://forge.typo3.org/issues/80899
     *
     * @param string $content
     *
     * @return array|string[]
     */
    public function splitHTMLContent($content)
    {
        $result =  parent::splitHTMLContent($content);
        /** @var \TYPO3\CMS\Core\MetaTag\MetaTagManagerRegistry $metaTagManagerRegistry */
        $metaTagManagerRegistry = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(\TYPO3\CMS\Core\MetaTag\MetaTagManagerRegistry::class);

        if (empty($result['title']) && $GLOBALS['TSFE'] instanceof \TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController) {
            /** @var \TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController $tsfe */
            $tsfe = $GLOBALS['TSFE'];

            if (isset($tsfe->page['seo_title'])) {
                $result['title'] = $tsfe->page['seo_title'];
            } else if (isset($tsfe->page['title'])) {
                $result['title'] = $tsfe->page['title'];
            }
        }

        if (empty($result['keywords'])) {
            $keywordsProperty = $metaTagManagerRegistry->getManagerForProperty('keywords')->getProperty('keywords');

            if (isset($keywordsProperty[0]['content'])) {
                $result['keywords'] = $keywordsProperty[0]['content'];
            }
        }

        if (empty($result['description'])) {
            $descriptionProperty = $metaTagManagerRegistry->getManagerForProperty('description')->getProperty('description');

            if (isset($descriptionProperty[0]['content'])) {
                $result['description'] = $descriptionProperty[0]['content'];
            }
        }

        return $result;
    }
}

ext_localconf.php

$GLOBALS['TYPO3_CONF_VARS']['SYS']['Objects'][\TYPO3\CMS\IndexedSearch\Indexer::class] = array(
    'className' => \Vendor\YourExt\Indexer::class
);
Actions
Copy link
 #4

Updated by Riccardo De Contardi over 3 years ago

  • Parent task set to #65815
Actions
Copy link
 #5

Updated by Tomas Norre Mikkelsen over 1 year ago

Cannot extract meta-data of what? PDFs or what is meant here?
Could you please add steps to reproduce?

Actions
Copy link
 #6

Updated by Christian Kuhn over 1 year ago

  • Status changed from New to Needs Feedback
Actions
Copy link

Also available in: Atom PDF