Project

General

Profile

Actions
Copy link

Bug #82057

closed

file:current:crop does not work anymore for page media resources

Added by Markus Timtner over 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Wolfgang Klinger
Category:
Image Cropping
Target version:
next-patchlevel
Start date:
2017-08-08
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.0
Tags:
fluid_styled_content, menu, typoscript, file:current:crop
Complexity:
medium
Is Regression:
Yes
Sprint Focus:
On Location Sprint

Description

If one adds an image in page media resources and decides to crop it,
the cropping data isn't passed through "data" anymore.

This used to work in v7!

References:
http://www.typo3-probleme.de/2017/02/01/typo3-7-6-seiteneigenschaften-bild-ressourcen-via-fluid-auslesen-1897/
http://www.typo3forum.net/discussion/78240/menue-der-unterseiten-mit-bild-jetzt-fuer-fluid-styled-content-und-richtigem-ausschnitt-crop

For Testing, I have this fsc Tempate for MenuAbstract:

<html xmlns:f="http://typo3.org/ns/TYPO3/CMS/Fluid/ViewHelpers" data-namespace-typo3-fluid="true">
<f:layout name="Default" />
<f:section name="Main">

    <f:if condition="{menu}">
        <ul>
            <f:for each="{menu}" as="page">
                <li>
                    <a href="{page.link}" target="{page.target}" title="{page.title}">
                        <span>{page.title}</span>
                    </a>
                    <f:if condition="{page.data.abstract}">
                        <f:format.html>{page.data.abstract}</f:format.html>
                    </f:if>
                    <f:if condition="{page.data.media}">
                        <f:debug title="My Debug Statement" inline="1">{page}</f:debug>
                        <f:cObject typoscriptObjectPath="lib.pageimage" data="{page.data}"  />
                    </f:if>

                </li>
            </f:for>
        </ul>
    </f:if>

</f:section>
</html>

And this typoscript here:

lib.pageimage = FILES
lib.pageimage {
        references {
            table = pages
            #Seiten-ID ubergabe
            uid.dataWrap= {field:uid}
            fieldName = media
        }
        renderObj = IMAGE
        renderObj {
            file {
                treatIdAsReference = 1
                width       = 780c
                #height      = 380c
                import.data = file:current:uid
                crop.data   = file:current:crop
            }
            #altText.data = file:current:alternative
            altText.data = file:current:crop
            params = class="img-responsive" 
            wrap = |
        }
    }
}

For testing, I have the contents of "file:current:crop" in altText.data, which yields:

alt=',"selectedRatio":"NaN","focusArea":null}}'

The same typoscript works in v7 as expected, altText.data shows this result:

alt="{&quot;x&quot;:207.1372549019608,&quot;y&quot;:105.4656862745098,&quot;width&quot;:265,&quot;height&quot;:165.5,&quot;rotate&quot;:0}"

Anybody any ideas?
If someone can point me in the right direction I will have a look.

Related issues 2 (0 open — 2 closed)

Related to TYPO3 Core - Bug #71164: ImageManipulation Using in Page Resources Media RelationClosed2015-10-30

Actions
Related to TYPO3 Core - Story #75880: Add art direction capabilities to BEClosed2017-02-23

Actions
Actions
Copy link
 #1

Updated by Markus Timtner over 6 years ago

(there is a surplus "}" at the end of the typoscript, sorry for that - editing here in redmine sucks.)

Actions
Copy link
 #2

Updated by Josef Glatz over 6 years ago

  • Related to Bug #71164: ImageManipulation Using in Page Resources Media Relation added
Actions
Copy link
 #3

Updated by Josef Glatz over 6 years ago

  • Status changed from New to Accepted

I can confirm the issue

Actions
Copy link
 #4

Updated by Wolfgang Klinger over 6 years ago

I tested with master and the output is

{"default":{"cropArea":{"height":0.661,"width":0.9745508982035929,"x":0.02245508982035928,"y":0.207},"selectedRatio":"NaN","focusArea":null}}

which looks fine, right?

Actions
Copy link
 #5

Updated by Markus Timtner over 6 years ago

Yes, this output seems right.
So are you able to see the cropped image in the frontend?

Actions
Copy link
 #6

Updated by Wolfgang Klinger over 6 years ago

and I tested with 8.7.5-dev

the output is:

{"default":{"cropArea":{"height":0.5,"width":1,"x":0,"y":0.086},"selectedRatio":"4:3","focusArea":null}}

Actions
Copy link
 #7

Updated by Wolfgang Klinger over 6 years ago

I just want to nail down the cause ;-)
no, the image is not cropped, but the settings seem to be there … I'll investigate further.

Actions
Copy link
 #8

Updated by Wolfgang Klinger over 6 years ago

  • Assignee set to Wolfgang Klinger
Actions
Copy link
 #9

Updated by Markus Timtner over 6 years ago

if you need any help or testing, just contact me (@Markus Timtner) via slack -
I have a working test case ready here.

Actions
Copy link
 #10

Updated by Wolfgang Klinger over 6 years ago

  • Related to Story #75880: Add art direction capabilities to BE added
Actions
Copy link
 #11

Updated by Gerrit Code Review over 6 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717

Actions
Copy link
 #12

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717

Actions
Copy link
 #13

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717

Actions
Copy link
 #14

Updated by Gerrit Code Review over 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717

Actions
Copy link
 #16

Updated by Gerrit Code Review over 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717

Actions
Copy link
 #17

Updated by Gerrit Code Review over 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717

Actions
Copy link
 #18

Updated by Peter Kraume over 6 years ago

The latest patch version works fine in production! Can we get this patch in the core soon, please?

Actions
Copy link
 #19

Updated by Gerrit Code Review over 6 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717

Actions
Copy link
 #20

Updated by Benni Mack over 6 years ago

  • Sprint Focus set to On Location Sprint
Actions
Copy link
 #21

Updated by Gerrit Code Review over 6 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717

Actions
Copy link
 #22

Updated by Gerrit Code Review over 6 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717

Actions
Copy link
 #23

Updated by Gerrit Code Review over 6 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717

Actions
Copy link
 #24

Updated by Gerrit Code Review over 6 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717

Actions
Copy link
 #25

Updated by Gerrit Code Review over 6 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717

Actions
Copy link
 #26

Updated by Gerrit Code Review over 6 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717

Actions
Copy link
 #27

Updated by Gerrit Code Review over 6 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717

Actions
Copy link
 #28

Updated by Gerrit Code Review over 6 years ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717

Actions
Copy link
 #29

Updated by Gerrit Code Review over 6 years ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53717

Actions
Copy link
 #30

Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55147

Actions
Copy link
 #31

Updated by Wolfgang Klinger over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #32

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF