Project

General

Profile

Actions

Task #83396

closed

sysExt:form FinisherVariableProvider access objects

Added by Simon Kerber over 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Form Framework
Target version:
-
Start date:
2017-12-20
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The structure of the FinisherVariableProvider is very rigid and do not allow to iterate through all iterator variables. Since this class is used for the communication between finishers, there might be a use case when you need to iterate through all finisher variables, without knowing their ids.

The solution is to add a getter:

getObjects() {
return $this->objects;
}

Important keyword: API First

Also, I see no reason why this class should be final. Heck, not a single class in the sysext is final...

Actions #1

Updated by Björn Jacob over 6 years ago

  • Tracker changed from Bug to Task
  • TYPO3 Version changed from 8 to 9

I do not consider this as a bug. We cannot change the architecture within a LTS version. We will discuss your issue for v9.

Actions #2

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55308

Actions #3

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55308

Actions #4

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55308

Actions #5

Updated by Ralf Zimmermann over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF