Project

General

Profile

Actions

Bug #85778

closed

Discarding file reference change makes appear different/more change entries

Added by NGUYEN Duc Quan almost 6 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Workspaces
Target version:
-
Start date:
2018-08-08
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.0
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

I noticed something strange and can't get my head around it.

When replacing an image in page edit under resources->media in a workspace (draft mode)
and then discarding the change I get more entries (seems like a detailed list of changes, deleting, replacing, ...) instead of the page change which is marked as edited.

This can be reproduced by:
- adding a page in live mode
- set an image in page resources
- switching to draft workspace/mode
- deleting added image and adding new image
- go to workspaces menu/view in draft mode
- edit change on page is shown
- delete the change

=> instead of one change entry (edit) you get two (deletion & creation of the file references)

I noticed this issue in our dev environment so I also tested this in a clean Typo3 v8.7.18 installation with only predefined and the workspace extensions to verify this issue.

The added video illustrates the steps to reproduce the issue.


Files

Workspace.mov (10.6 MB) Workspace.mov NGUYEN Duc Quan, 2018-08-08 10:35

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #92336: Separate 'delete' and 'discard' in DataHandlerClosed2020-09-18

Actions
Actions #1

Updated by NGUYEN Duc Quan almost 6 years ago

  • Priority changed from Should have to Must have
Actions #2

Updated by NGUYEN Duc Quan over 5 years ago

After looking at this issue again I noticed that the (two additional) change entries where collapsed in (/hidden) to begin with.

But shouldn't these two changes be also discarded when the "parent"/master change have been discarded?

Actions #3

Updated by Riccardo De Contardi about 4 years ago

This issue seems still present on 10.4.2-dev (latest master)

Actions #4

Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 79 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65638

Actions #5

Updated by Christian Kuhn over 3 years ago

  • Related to Bug #92336: Separate 'delete' and 'discard' in DataHandler added
Actions #6

Updated by Gerrit Code Review over 3 years ago

Patch set 80 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65638

Actions #7

Updated by Gerrit Code Review over 3 years ago

Patch set 81 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65638

Actions #8

Updated by Christian Kuhn over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Gerrit Code Review over 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65766

Actions #10

Updated by Christian Kuhn over 3 years ago

  • Status changed from Under Review to Resolved
Actions #11

Updated by Benni Mack over 3 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF