TYPO3 Core

@Chris Müller
Does this work for you now? I'm having serious trouble getting the sitemap to work at all, neither / nor /de/ as base language segment works for me

The topic of this report is wrong, it's not just the sitemap.xml, but in general all static routes and redirects are screwed up, if there is no entrypoint with just a "/"

--Update--
I think i found the culprit: the SiteBaseRedirect should only kick in, in the documented case:

// Usually called when "https://www.example.com" was entered, but all sites have "https://www.example.com/lang-key/" 
// So a redirect to the first possible language is done.

But since there is no check, if the called url is actually "empty", it just handles everything that can not be mapped to a configured language.

This is basically done on purpose, as you can have multiple sites with the same base and different language configurations.

If two sites had / as base (and lang configs) which static route config is to be taken? The configuration in this case is undefined and instead of doing unpredictable "magic" by chosing any one of them, we are currently only using the config that is defined.

I agree. For me, this issue can be closed.

I don't understand: static routes are defined per sites, so even if two sites have / as base it should not be a problem.

The only way to make static routes work in a multi-language site is to have the default language with / as a base?

Susanne Moog wrote:

This is basically done on purpose, as you can have multiple sites with the same base and different language configurations.

If two sites had / as base (and lang configs) which static route config is to be taken? The configuration in this case is undefined and instead of doing unpredictable "magic" by chosing any one of them, we are currently only using the config that is defined.

We tried to find a solution for all use cases but unfortunately this is not possible with the current architecture of static routes. The main design flaw is that static routes are bound to sites but sites do not have to be exclusive in terms of their base. This leads to an arbitrary static route resolving.

To circumvent the current restriction on site configurations that have no dedicated entry point "/" please consider rearranging the Middlewares in your installation. Refer to the documentation on how this can be achieved: https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ApiOverview/RequestHandling/Index.html#override-ordering-of-middlewares

In the long run we need to decouple static routes from site configuration and treat them more like redirects are treated now. They need to be globally defined to remove the arbitrariness when resolving. In this case we could think about serving them in a dedicated sysext (like redirects) because then the functionality could be removed completely if not needed (to reduce bloat).

somebody have nothing better to do than to put unfinished system online? .. oh wait free T3v8 support until "2020-03-31" ..incompetent or calculating? i thing it's just financed foresight :)

Couldn't we use the reordering feature switch rearrangedRedirectMiddlewares that has been used to fix the same problem with redirects?

https://forge.typo3.org/issues/88902
https://forge.typo3.org/projects/typo3cms-core/repository/revisions/ffd69f0bc8ebf23dbb4d736a058746bbbde5f08d/diff/typo3/sysext/redirects/Configuration/RequestMiddlewares.php

Markus Mächler wrote:

Couldn't we use the reordering feature switch rearrangedRedirectMiddlewares that has been used to fix the same problem with redirects?

https://forge.typo3.org/issues/88902
https://forge.typo3.org/projects/typo3cms-core/repository/revisions/ffd69f0bc8ebf23dbb4d736a058746bbbde5f08d/diff/typo3/sysext/redirects/Configuration/RequestMiddlewares.php

Yes, as Daniel stated in #11 this is a valid work around in your projects - however, it is not a solution we could use in the core for the issues and cases mentioned above.

Thanks for the explanations. What about including this with the same feature switch and throwing an InvalidSiteConfigurationException or something in case two sites with the same base but different language settings define the same static route? This could be an intermediate step for TYPO3 10 LTS until static routes are redesigned completely.

This should be solved if #89518 is done - it's currently pending and you could help out by reviewing and testing the patch.