Project

General

Profile

Actions

Bug #86888

closed

PseudoSiteFinder: All found languages have iso en

Added by Alexander Opitz over 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend API
Start date:
2018-11-08
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The PseudoSiteFinder aggregates all languages defined in sys_languages and builds from this an array in following form

$languageRecords[$uid] = [
    'languageId' => $uid,
    'title' => $row['title'],
    'iso' => $row['language_isocode'] ?? '',
    'flag' => 'flags-' . $row['flag'],
];

The NullSite class takes this array and creates for every Language an instance of SiteLanguage and gives the per language array as $attributes to the constructor. But SiteLanguage handles following array form

$attributes[
    'title' => ,
    'navigationTitle' => ,
    'flag' => ,
    'typo3Language' => ,
    'iso-639-1' => ,
    'hreflang' => ,
    'direction' => ,
    'fallbackType' => ,
    'fallbacks' => ,
    'enabled' => ,
];

Also hidden sys_languages are inside array, but the enabled field isn't set in the array.

Actions #1

Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58874

Actions #2

Updated by Alexander Opitz over 5 years ago

  • Description updated (diff)
Actions #3

Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58874

Actions #4

Updated by Alexander Opitz over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Benni Mack about 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF