Project

General

Profile

Actions
Copy link

Bug #87772

closed

validateRstFiles Script does not recognize Features for stable branches

Added by Anja Leichsenring about 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Anja Leichsenring
Category:
-
Target version:
-
Start date:
2019-02-23
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The script should check rst files for necessary parts, but it is a little bit too greedy. Features and Important files do not require a *Scanned index entry, but this is currently ignored.

This would be valid file pathes, where no *Scanned index entries are required:

typo3/sysext/core/Documentation/Changelog/9.5.1/Feature-87748-AddSiteProcessor.rst
typo3/sysext/core/Documentation/Changelog/9.5.x/Feature-87748-AddSiteProcessor.rst
typo3/sysext/core/Documentation/Changelog/master/Feature-87748-AddSiteProcessor.rst
typo3/sysext/core/Documentation/Changelog/9.5/Feature-87748-AddSiteProcessor.rst

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Task #87774: Adjust rst file indizes for proper validationClosedAnja Leichsenring2019-02-24

Actions
Actions
Copy link
 #1

Updated by Gerrit Code Review about 5 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59790

Actions
Copy link
 #2

Updated by Gerrit Code Review about 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59790

Actions
Copy link
 #3

Updated by Stephan Großberndt about 5 years ago

typo3/sysext/core/Documentation/Changelog/9.5.1/Feature-87748-AddSiteProcessor.rst

is not valid, the others are valid.

Actions
Copy link
 #4

Updated by Stephan Großberndt about 5 years ago 

$filenames = [

    'typo3/sysext/core/Documentation/Changelog/master/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst',
    'typo3/sysext/core/Documentation/Changelog/master/Feature-58637-PurgeLanguagePacksInLanguageModule.rst',
    'typo3/sysext/core/Documentation/Changelog/9.5.x/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst',
    'typo3/sysext/core/Documentation/Changelog/9.5.x/Feature-58637-PurgeLanguagePacksInLanguageModule.rst',
    'typo3/sysext/core/Documentation/Changelog/9.5/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst',
    'typo3/sysext/core/Documentation/Changelog/9.5/Feature-58637-PurgeLanguagePacksInLanguageModule.rst',
    'typo3/sysext/core/Documentation/Changelog/8.7.x/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst',
    'typo3/sysext/core/Documentation/Changelog/8.7.x/Feature-58637-PurgeLanguagePacksInLanguageModule.rst',
    'typo3/sysext/core/Documentation/Changelog/8.7/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst',
    'typo3/sysext/core/Documentation/Changelog/8.7/Feature-58637-PurgeLanguagePacksInLanguageModule.rst',

    'typo3/sysext/core/Documentation/Changelog/9.5.1/Feature-87748-AddSiteProcessor.rst',
    'typo3/sysext/core/Documentation/Changelog/9.5.x/Feature-87748-AddSiteProcessor.rst',
    'typo3/sysext/core/Documentation/Changelog/master/Feature-87748-AddSiteProcessor.rst',
    'typo3/sysext/core/Documentation/Changelog/9.5/Feature-87748-AddSiteProcessor.rst',
];

foreach ($filenames as $filename) {
    echo preg_match('#'
            . 'Changelog/'             # Ignore all Changelog files
            . '('                      # which are either
            . '.+/(Feature|Important)' # of type "Feature" and "Important" from any version
            . '|'                      # or
            . '([78]\.\d(\.[0-9x])?)'  # from 7.x and 8.x (as there was no extension scanner back then)
            . ')'
            . '#x', $filename) . ' ' . $filename . PHP_EOL;
}

0 typo3/sysext/core/Documentation/Changelog/master/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst
1 typo3/sysext/core/Documentation/Changelog/master/Feature-58637-PurgeLanguagePacksInLanguageModule.rst
0 typo3/sysext/core/Documentation/Changelog/9.5.x/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst
1 typo3/sysext/core/Documentation/Changelog/9.5.x/Feature-58637-PurgeLanguagePacksInLanguageModule.rst
0 typo3/sysext/core/Documentation/Changelog/9.5/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst
1 typo3/sysext/core/Documentation/Changelog/9.5/Feature-58637-PurgeLanguagePacksInLanguageModule.rst
1 typo3/sysext/core/Documentation/Changelog/8.7.x/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst
1 typo3/sysext/core/Documentation/Changelog/8.7.x/Feature-58637-PurgeLanguagePacksInLanguageModule.rst
1 typo3/sysext/core/Documentation/Changelog/8.7/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst
1 typo3/sysext/core/Documentation/Changelog/8.7/Feature-58637-PurgeLanguagePacksInLanguageModule.rst
1 typo3/sysext/core/Documentation/Changelog/9.5.1/Feature-87748-AddSiteProcessor.rst
1 typo3/sysext/core/Documentation/Changelog/9.5.x/Feature-87748-AddSiteProcessor.rst
1 typo3/sysext/core/Documentation/Changelog/master/Feature-87748-AddSiteProcessor.rst
1 typo3/sysext/core/Documentation/Changelog/9.5/Feature-87748-AddSiteProcessor.rst
Actions
Copy link
 #5

Updated by Gerrit Code Review about 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59790

Actions
Copy link
 #6

Updated by Gerrit Code Review about 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59790

Actions
Copy link
 #7

Updated by Gerrit Code Review about 5 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59790

Actions
Copy link
 #8

Updated by Anja Leichsenring about 5 years ago

  • Related to Task #87774: Adjust rst file indizes for proper validation added
Actions
Copy link
 #9

Updated by Gerrit Code Review about 5 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59790

Actions
Copy link
 #10

Updated by Gerrit Code Review about 5 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59790

Actions
Copy link
 #11

Updated by Gerrit Code Review about 5 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59790

Actions
Copy link
 #12

Updated by Gerrit Code Review about 5 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59818

Actions
Copy link
 #13

Updated by Gerrit Code Review about 5 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59819

Actions
Copy link
 #14

Updated by Anonymous about 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #15

Updated by Benni Mack almost 5 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF