Project

General

Profile

Actions

Bug #89858

closed

Inline-Records not correctly overlayed with workspaces

Added by Philipp Seiler over 4 years ago. Updated 2 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
Category:
Workspaces
Target version:
-
Start date:
2019-12-05
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
inline,irre,record,relation,hidden,sorting
Complexity:
Is Regression:
Sprint Focus:

Description

  • Create some content element which contains inline records (type = inline, foreign_table, ...).
  • Add inline records in the live-non-workspaced version.
  • Switch to a workspace.
  • Edit the just created content element and hide some previously created inline records.
  • Save the content element. After reload, the elements are still shown ans "active" in the backend, which is of course incorrect. The frontend preview-output is correct however.

Reason seems to be, that in the class \TYPO3\CMS\Backend\Form\FormDataProvider\TcaInline the records are fetched without overlaying them with the workspace. The class \TYPO3\CMS\Backend\Form\Container\InlineControlContainer simply outputs the state of the non versioned records. The versioned records (pid = -1) however do contain the correct hidden-state.

Same behaviour goes for sorting inline records in the workspace. If sorting is changed in the workspace and then published to live, the sorting is lost again.


Related issues 2 (1 open1 closed)

Related to TYPO3 Core - Bug #95328: Sorting inline elements in workspace does not work for preview New2021-09-23

Actions
Related to TYPO3 Core - Bug #97548: In workspaces translated inline element items are shown twiceResolved2022-05-04

Actions
Actions #1

Updated by Ralf Hübner over 2 years ago

Hi Philipp,

i have a similar problem in 10.4.20.

Change the sorting "Irre" elements in Draft-workspace and call a preview. The sorting does not take into account, the sorting is "used" from live-version.
However, the sorting in backend is correct for draft and live.

Actions #2

Updated by Benni Mack over 2 years ago

  • Related to Bug #95328: Sorting inline elements in workspace does not work for preview added
Actions #3

Updated by Benni Mack over 2 years ago

  • Status changed from New to Needs Feedback

Does this happen in Extbase or in TypoScript context?

Actions #4

Updated by Benni Mack over 1 year ago

  • Status changed from Needs Feedback to Closed

Closing this ticket now due to lack of feedback. If you feel this issue is still a problem, let me know and I will re-open the ticket.

Actions #5

Updated by bahne claussen over 1 year ago

  • Assignee set to Benni Mack

There is still a problem with Irre elements in Workspaces. When we translate an element with Irre elements, they are displayed twice in workspaces.

steps to reproduce:

- switch to the workspace and edit an Irre element in DE
- after saving call the english version of the element
- Now all Irre elements are duplicated and disabled
- If you now create a new element all elements are not visible in the frontend

When we leave the workspace all elements are normal again

Actions #6

Updated by Thomas Bauer-Philippi about 1 year ago

bahne claussen wrote in #note-5:

There is still a problem with Irre elements in Workspaces. When we translate an element with Irre elements, they are displayed twice in workspaces.

steps to reproduce:

- switch to the workspace and edit an Irre element in DE
- after saving call the english version of the element
- Now all Irre elements are duplicated and disabled
- If you now create a new element all elements are not visible in the frontend

When we leave the workspace all elements are normal again

We experienced a similar problem, maybe it's even the same problem.

- TYPO3 11.5.24
- Mask 8.0.6

When we edit a mask record with IRRE elements in the default language in the draft workspace, all elements get duplicated in other languages (translated IRRE elements + disabled/unlocalized IRRE elements). Everything works as expected in the default/public workspace.

Actions #7

Updated by Benni Mack about 1 year ago

  • Status changed from Closed to Accepted
Actions #8

Updated by Benni Mack 10 months ago

  • Related to Bug #97548: In workspaces translated inline element items are shown twice added
Actions #9

Updated by Gerrit Code Review 2 months ago

  • Status changed from Accepted to Under Review

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82996

Actions #10

Updated by Gerrit Code Review 2 months ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82996

Actions #11

Updated by Gerrit Code Review 2 months ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82996

Actions #12

Updated by Gerrit Code Review 2 months ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82996

Actions #13

Updated by Gerrit Code Review 2 months ago

Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82996

Actions #14

Updated by Gerrit Code Review 2 months ago

Patch set 10 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82996

Actions #15

Updated by Gerrit Code Review 2 months ago

Patch set 11 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82996

Actions #16

Updated by Gerrit Code Review 2 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83165

Actions #17

Updated by Christian Kuhn 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF