Bug #91185: HMENU does not link to showAccessRestrictedPages for non-default language - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #91185

closed

HMENU does not link to showAccessRestrictedPages for non-default language

Added by Jonas Eberle about 4 years ago. Updated almost 4 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Localization

Target version:

Start date:

2020-04-24

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

language overlay pages

Complexity:

Is Regression:

Sprint Focus:

Description

Minimum test case:

have 2 languages (fallbackType: 'strict' - for me the output is the same for 'fallback', though)
add a page and translate it
put an access restriction on the page (e.g. "Show at any login [-2]")

This

page {
  1 = HMENU
  1 {
    1 = TMENU
    1 {
      showAccessRestrictedPages = 1
      showAccessRestrictedPages.addParams = &return_url=###RETURN_URL###&pageId=###PAGE_ID###
      NO = 1
      NO.allWrap = <li>|</li>
      wrap = <ul>|</ul>
    }
    2 < .1
    3 < .1
  }
}

would render the expected &return_url for the default language, but a direct link to the access restricted page for other languages.

Affects: MenuProcessor
Tested with 9.5.16-dev
Not reproducible in TYPO3v10

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Jonas Eberle about 4 years ago

I don't know if it makes any difference. This was set in my test setup as well:

config {
    typolinkLinkAccessRestrictedPages = 1
    typolinkLinkAccessRestrictedPages_addParams = &return_url=###RETURN_URL###&pageId=###PAGE_ID###
}

Pure typolink works as expected.

Actions

Copy link

Updated by Jonas Eberle about 4 years ago

TYPO3 Version changed from 9 to 10

v10 is also affected.

Sorry, the outcome of my earlier testcase was a bit borked because my data was not clean.
(pages.l18n_cfg = 0 for all pages, pages.fe_group set for default AND other language [that is how the backend does it]) <- so absolutely default now.

So here is the behaviour for both v9 and v10 (both current git):

stict (including [FE][hidePagesIfNotTranslatedByDefault] = true as per https://forge.typo3.org/issues/85987#note-15 this seems to be needed for strict mode):

The restricted page is not shown at all (although it is translated).

fallback:

The default language page's title is shown.

I am setting this issue to TYPO3 v10 as I am not sure if it qualifies to be fixed in v9 at all.

Actions

Copy link

Updated by Jonas Eberle about 4 years ago

Related to Bug #85987: Menus doesn't respect language settings and show non translated pages added

Actions

Copy link

Updated by Jonas Eberle about 4 years ago

Related to Bug #88987: Menu Generation Fails on Translated Websites added

Actions

Copy link

Updated by Jonas Eberle about 4 years ago

\TYPO3\CMS\Core\Domain\Repository\PageRepository::getPageOverlaysForLanguageUids needs to know that it should lift the fe_group restrictions.

Actions

Copy link

Updated by Gerrit Code Review about 4 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64318

Actions

Copy link

Updated by Jonas Eberle about 4 years ago

Category changed from TypoScript to Localization
Tags set to language overlay pages

Actions

Copy link

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset 56269a975cb2d71bada701796f2c20f2fc68b86e.

Actions

Copy link

#14

Updated by Gerrit Code Review almost 4 years ago

Status changed from Resolved to Under Review

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64359

Actions

Copy link

#15