Project

General

Profile

Actions

Bug #97303

closed

ContentObjectRenderer http_makelinks replace https URLs with http URLs

Added by Achim Fritz about 2 years ago. Updated 10 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Content Rendering
Target version:
-
Start date:
2022-04-05
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
8.1
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

having a Fluid-Template with

<f:format.html>https://foo.bar.de/</f:format.html>

renders

<p><a href="http://foo.bar.de/" target="_blank" rel="noreferrer">foo.bar.de</a></p>

same error when using lib.parseFunc instead of lib.parseFunc_RTE

<f:format.html parseFuncTSPath="lib.parseFunc">https://foo.bar.de/</f:format.html>

renders:
<a href="http://foo.bar.de/" target="_blank" rel="noreferrer">foo.bar.de</a>

i think the schema should be readdet when calling typolink in http_makelinks

index debc7b9e74..48c3f1ec02 100644
--- a/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php
+++ b/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php
@@ -3743,7 +3743,7 @@ class ContentObjectRenderer implements LoggerAwareInterface
                         }
                     }
                     $typolinkConfiguration = $conf;
-                    $typolinkConfiguration['parameter'] = $parts[0];
+                    $typolinkConfiguration['parameter'] = $scheme . $parts[0];
                     $textstr .= $this->typoLink($linktxt, $typolinkConfiguration) . $parts[1];
                 } else {
                     $textstr .= $scheme . $textpieces[$i];

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Task #97444: Add unit tests for mailto_makelinksClosedSimon Schaufelberger2022-04-21

Actions
Related to TYPO3 Core - Bug #97457: Use proper LinkFactory setup for newly added unit testsClosed2022-04-22

Actions
Actions #1

Updated by Gerrit Code Review about 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74181

Actions #2

Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74181

Actions #3

Updated by Gerrit Code Review about 2 years ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74181

Actions #4

Updated by Simon Schaufelberger about 2 years ago

  • Related to Task #97444: Add unit tests for mailto_makelinks added
Actions #5

Updated by Gerrit Code Review about 2 years ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74181

Actions #6

Updated by Gerrit Code Review about 2 years ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74181

Actions #7

Updated by Gerrit Code Review about 2 years ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74310

Actions #8

Updated by Anonymous about 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Gerrit Code Review about 2 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74310

Actions #10

Updated by Gerrit Code Review about 2 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74311

Actions #11

Updated by Anonymous about 2 years ago

  • Status changed from Under Review to Resolved
Actions #12

Updated by Gerrit Code Review about 2 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74311

Actions #13

Updated by Stefan Bürk about 2 years ago

  • Related to Bug #97457: Use proper LinkFactory setup for newly added unit tests added
Actions #14

Updated by Riccardo De Contardi 10 months ago

  • Status changed from Under Review to Closed

As far as I can see the patch has been abandoned on version 10 and is already merged on 11 => closing it

If you think that this is the wrong decision, please reopen it or ping me and I'll do it.

Actions

Also available in: Atom PDF