Feature #14037
Translation files (XLIFF) must be possible per package
100%
Description
Currently the XliffTranslationProvider uses a hardcoded base path to look for XLIFF files of resource://FLOW3/Private/Locale/Translations/.
But it is necessary to have translations in each package, as it does not make sense to have labels for the Blog package in the FLOW3 package.
Also the TranslateViewHelper needs to offer the use of labels from different packages - e.g. to use labels from the Blog by default but fetch labels for the login screen from a shared file in the FLOW3 package.
Related issues
Associated revisions
[FEATURE] Allow translation files (XLIFF) on a per package basis
Fixes issue in which XliffTranslationProvider prefaces a hardcoded
base path of resource://FLOW3/Private/Locale/Translations before
the sourceName argument passed to getTranslationByOriginalLabel and
getTranslationById methods.
This fix modifies the translateById and translateByOriginalLabel
methods in the TYPO3\FLOW3\I18n\Translator to use packageKey
as an argument. The XliffTranslationProvider will construct a
base path of "<packageName>/Private/Locale/Translations". This base
path is prepended to the value of the sourceName argument to create
the translation file resource string.
Unit tests have been adjusted as well to accommodate these changes
to the XliffTranslationProvider and Translator classes. The
TranslationProviderInterface has been adjusted as well.
Change-Id: Iff62c0dc4cf47f8b2d5a9d143132ab64e2012891
Resolves: #14037
Releases: 1.1
History
#1
Updated by Karsten Dambekalns about 8 years ago
Updated by - Status changed from New to Accepted
- Assignee set to Karsten Dambekalns
#2
Updated by Karsten Dambekalns almost 8 years ago
- Target version changed from 1.0 beta 1 to 1.1
#3
Updated by Mr. Hudson almost 8 years ago
Updated by - Status changed from Accepted to Under Review
Patch set 1 of change Iff62c0dc4cf47f8b2d5a9d143132ab64e2012891 has been pushed to the review server.
It is available at http://review.typo3.org/4430
#4
Updated by Mr. Hudson almost 8 years ago
Patch set 1 of change Ic2b9fe9e2ce20d37ec422c15acc76500e86063cf has been pushed to the review server.
It is available at http://review.typo3.org/4431
#5
Updated by Mr. Hudson almost 8 years ago
Patch set 2 of change Iff62c0dc4cf47f8b2d5a9d143132ab64e2012891 has been pushed to the review server.
It is available at http://review.typo3.org/4430
#6
Updated by Mr. Hudson almost 8 years ago
Patch set 2 of change Ic2b9fe9e2ce20d37ec422c15acc76500e86063cf has been pushed to the review server.
It is available at http://review.typo3.org/4431
#8
Updated by Karsten Dambekalns over 7 years ago
- Tracker changed from Bug to Feature
#9
Updated by Mr. Hudson over 7 years ago
Patch set 3 of change Ic2b9fe9e2ce20d37ec422c15acc76500e86063cf has been pushed to the review server.
It is available at http://review.typo3.org/4431
#10
Updated by Mr. Hudson over 7 years ago
Patch set 4 of change Ic2b9fe9e2ce20d37ec422c15acc76500e86063cf has been pushed to the review server.
It is available at http://review.typo3.org/4431
#11
Updated by Mr. Jenkins over 7 years ago
Updated by Patch set 3 of change Iff62c0dc4cf47f8b2d5a9d143132ab64e2012891 has been pushed to the review server.
It is available at http://review.typo3.org/4430
#12
Updated by Mr. Jenkins over 7 years ago
Patch set 4 of change Iff62c0dc4cf47f8b2d5a9d143132ab64e2012891 has been pushed to the review server.
It is available at http://review.typo3.org/4430
#13
Updated by Gerrit Code Review over 7 years ago
Updated by Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/4430
#14
Updated by Karsten Dambekalns over 7 years ago
- % Done changed from 0 to 100
#15
Updated by Karsten Dambekalns over 7 years ago
- Status changed from Under Review to Resolved
#16
Updated by Karsten Dambekalns over 7 years ago
- Target version changed from 1.1 to 1.1 beta 1