Bug #25906

Injection with settings use breaks

Added by Karsten Dambekalns almost 9 years ago. Updated almost 9 years ago.

Status:
Resolved
Priority:
Must have
Category:
Object
Start date:
2011-04-12
Due date:
% Done:

100%

PHP Version:
Has patch:
Complexity:

Description

If configuring injection in Objects.yaml and making use of settings for a factory there the generated proxy is broken, because it assumes $this->settings exists.

It should use the static object container to fetch settings instead.


Related issues

Blocks TYPO3.Flow - Feature #25882: Dedicated query log Resolved 2011-04-11

Associated revisions

Revision 888b03da (diff)
Added by Karsten Dambekalns almost 9 years ago

[BUGFIX] Injection with factory settings is usable again

If configuring injection in Objects.yaml and making use of settings for
a factory there, the generated proxy is broken, because it assumes
$this->settings exists.

Instead we use the static object container to fetch settings now.

Fixes: #25906
Change-Id: I15f86cc651935dbe756f5b02a155b5ff14c5e668

Revision 4fc6b9e4 (diff)
Added by Christopher Hlubek almost 9 years ago

[BUGFIX] Fix constructor setting injection for singletons

Change I15f86cc651935dbe756f5b02a155b5ff14c5e668 missed one spot for
setting injection in the ProxyClassBuilder.

This change also adds some additional functional tests for setting
injection.

Change-Id: Ie6310c9b1a01c879408c512c6808e8b9485cf744
Resolves: #25906

History

#1 Updated by Mr. Hudson almost 9 years ago

Patch set 1 of change I15f86cc651935dbe756f5b02a155b5ff14c5e668 has been pushed to the review server.
It is available at http://review.typo3.org/1767

#2 Updated by Karsten Dambekalns almost 9 years ago

  • Status changed from Accepted to Under Review

#3 Updated by Mr. Hudson almost 9 years ago

Patch set 2 of change I15f86cc651935dbe756f5b02a155b5ff14c5e668 has been pushed to the review server.
It is available at http://review.typo3.org/1767

#4 Updated by Mr. Hudson almost 9 years ago

Patch set 3 of change I15f86cc651935dbe756f5b02a155b5ff14c5e668 has been pushed to the review server.
It is available at http://review.typo3.org/1767

#5 Updated by Mr. Hudson almost 9 years ago

Patch set 4 of change I15f86cc651935dbe756f5b02a155b5ff14c5e668 has been pushed to the review server.
It is available at http://review.typo3.org/1767

#6 Updated by Karsten Dambekalns almost 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Christopher Hlubek almost 9 years ago

  • Status changed from Resolved to Under Review
  • % Done changed from 100 to 80

I have to reopen this issue since constructor injection of settings wasn't fixed. I pushed a new change with additional functional tests.

#8 Updated by Mr. Hudson almost 9 years ago

Patch set 1 of change Ie6310c9b1a01c879408c512c6808e8b9485cf744 has been pushed to the review server.
It is available at http://review.typo3.org/1933

#9 Updated by Christopher Hlubek almost 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 80 to 100

Also available in: Atom PDF