Bug #25966

ResourcePointer breaks if you upload the same file twice

Added by Andreas Förthner almost 10 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Must have
Category:
Persistence
Start date:
2011-04-14
Due date:
% Done:

100%

Estimated time:
PHP Version:
Has patch:
Complexity:

Description

As ResourcePointer is no valueobject (for doctrine) anymore, the resource manager creates a second one for the same file, if you upload it twice. Now the sha1 hash is the identifier of the ResourcePointer, and therefore we get a duplicate entry error from the database as we have twice the "same" object.


Related issues

Related to TYPO3.Flow - Bug #26886: Uploaded resources get lost on validation errorsResolvedSebastian Kurfuerst2011-05-18

Actions
Related to Conference Management - Task #26667: Fix Image Upload from pluginResolvedSebastian Kurfuerst2011-05-06

Actions
Blocks Conference Management - Story #26663: Solve FLOW3/Phoenix bugs for sprint "Call for Papers"Resolved2011-05-06

Actions
#1

Updated by Karsten Dambekalns almost 10 years ago

  • Category set to Resource
  • Target version set to 1.0 beta 1
#2

Updated by Karsten Dambekalns over 9 years ago

  • Status changed from New to Accepted
  • Assignee set to Karsten Dambekalns
#3

Updated by Karsten Dambekalns over 9 years ago

  • Category changed from Resource to Persistence
#4

Updated by Sebastian Kurfuerst over 9 years ago

  • Status changed from Accepted to Under Review
  • Assignee changed from Karsten Dambekalns to Sebastian Kurfuerst
  • % Done changed from 0 to 100
#5

Updated by Mr. Hudson over 9 years ago

Patch set 2 of change Ibc6970524967d18fdab84639f7d53ddcf8c27c00 has been pushed to the review server.
It is available at http://review.typo3.org/2222

#6

Updated by Bastian Waidelich over 9 years ago

Note: I think, the correct approach is, to always resend the uploaded file (e.g. it's resource pointer hash) on submit even if it was not changed. Just like other form fields.
This way you can reset the value to an empty string on order to remove an uploaded resource. Needs to be discussed though.

#7

Updated by Sebastian Kurfuerst over 9 years ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF