Bug #31270

Proxy classes loose @return and @throws annotations

Added by Karsten Dambekalns almost 10 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Must have
Category:
Object
Start date:
2011-10-25
Due date:
% Done:

100%

Estimated time:
PHP Version:
Has patch:
No
Complexity:

Description

The proxy classes built by FLOW3 no longer contain @throws and @return annotations. This breaks code relying on that, like the SOAP WSDL generator.


Related issues

Related to TYPO3.Flow - Bug #31452: IgnoreValidation with argumentName does not work for ActionControllerResolvedChristopher Hlubek2011-10-31

Actions
#1

Updated by Mr. Hudson almost 10 years ago

  • Status changed from Accepted to Under Review

Patch set 4 of change Ifcf5da2e4b43b917a85a1bea061e9ee8b33f1a50 has been pushed to the review server.
It is available at http://review.typo3.org/6163

#2

Updated by Christopher Hlubek over 9 years ago

Just a note: this breaks ignorevalidation on controllers since they are still using getMethodTagsValues which will return a wrong result if an annoation is written by the proxy builder like:

@TYPO3\FLOW3\Annotations\IgnoreValidation(argumentName="$service")

instead of

@TYPO3\FLOW3\Annotations\IgnoreValidation("$service")

I'll push a bugfix for the ActionController.

#3

Updated by Karsten Dambekalns over 9 years ago

Christopher Hlubek wrote:

I'll push a bugfix for the ActionController.

Thanks!

#4

Updated by Mr. Hudson over 9 years ago

Patch set 1 of change I9e68c42a227d6a978b74174cf02cd5940781b864 has been pushed to the review server.
It is available at http://review.typo3.org/6571

#5

Updated by Christopher Hlubek over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF