Bug #34527

Add method in repositories does also update

Added by Kira Backes over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Must have
Category:
Persistence
Start date:
2012-03-05
Due date:
% Done:

100%

Estimated time:
PHP Version:
Has patch:
No
Complexity:

Description

The add method in repositores does also update existing entities, this is a dangerous security flaw, as it allows an attacker to misuse creation forms (i.e. a register form) and change existing entities.

#1

Updated by Andreas Förthner over 9 years ago

  • Project changed from TYPO3 Flow Base Distribution to TYPO3.Flow
  • Assignee set to Andreas Förthner
#2

Updated by Karsten Dambekalns over 9 years ago

  • Category set to Security
  • Status changed from New to Accepted
  • Has patch set to No

Right, Doctrine doesn't differentiate between add and update in it's API. So we'd need to do this "on our side".

#3

Updated by Karsten Dambekalns over 9 years ago

  • Assignee changed from Andreas Förthner to Karsten Dambekalns
  • Target version set to 1.0.5
#4

Updated by Karsten Dambekalns over 9 years ago

  • Category changed from Security to Persistence
#5

Updated by Gerrit Code Review over 9 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/11595

#6

Updated by Karsten Dambekalns over 9 years ago

  • Target version changed from 1.0.5 to 1.1 beta 2
#7

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/11595

#8

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/11595

#9

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11715

#10

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch FLOW3-1.0 has been pushed to the review server.
It is available at http://review.typo3.org/11716

#11

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11715

#12

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch FLOW3-1.0 has been pushed to the review server.
It is available at http://review.typo3.org/11716

#13

Updated by Karsten Dambekalns over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#14

Updated by Gerrit Code Review over 9 years ago

  • Status changed from Resolved to Under Review

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11715

#15

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch FLOW3-1.0 has been pushed to the review server.
It is available at http://review.typo3.org/11716

#16

Updated by Karsten Dambekalns over 9 years ago

  • Status changed from Under Review to Resolved
#17

Updated by Gerrit Code Review over 9 years ago

  • Status changed from Resolved to Under Review

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11715

#18

Updated by Karsten Dambekalns over 9 years ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF