Bug #36720
Settings from package cannot override default value with empty array
100%
Description
A more specific setting file cannot override a list of values (array) with an empty array. The method arrayMergeRecursiveOverrule is not consistent in its logic, since setting NULL will also override the default, so this should also work with an empty array if emptyValuesOverride is TRUE.
We need that fix to override security firewall filters in functional tests. Besides that the current behaviour is not intuitive when treating NULL and empty arrays differently and limits extensibility.
A fix for this - while logically correct - causes problems when loading policies, such that roles from different packages or contexts override each other where they should be additive in behaviour.
Updated by Gerrit Code Review over 8 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10896
Updated by Gerrit Code Review over 8 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10896
Updated by Gerrit Code Review over 8 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10896
Updated by Gerrit Code Review over 8 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10896
Updated by Gerrit Code Review over 8 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10896
Updated by Gerrit Code Review about 8 years ago
Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10896
Updated by Gerrit Code Review almost 8 years ago
Patch set 8 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/10896
Updated by Gerrit Code Review almost 8 years ago
Patch set 9 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/10896
Updated by Gerrit Code Review almost 8 years ago
Patch set 10 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/10896
Updated by Christopher Hlubek almost 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset abdffa83a03ae660b9a850d87209312cb9843c08.
Updated by Gerrit Code Review almost 8 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/19568
Updated by Christopher Hlubek almost 8 years ago
- Status changed from Under Review to Resolved
Applied in changeset 339f877cf93665d25932a7a2da45b1a4c6b5c8ee.