Bug #36988

PropertyMapper chokes on Objects that are already converted

Added by Marc Neuhaus about 9 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Must have
Category:
Property
Start date:
2012-12-25
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
PHP Version:
Has patch:
No
Complexity:

Description

I've noticed that the PropertyMapper chokes on Objects which are already in the Target form.
This happened to me with the TYPO3.Form Project in case where the DatePickerViewHelper already transforms the Value to a DateTime and the FormHandler later tries to map it again which fails because he isn't supposed to handle objects.

In this case i would suggest, to check if the source property is of the target property and skip it in that case.

Here's the origination ticket:
http://forge.typo3.org/issues/36722#note-8


Files

PropertyMapper.diff (518 Bytes) PropertyMapper.diff Marc Neuhaus, 2012-05-13 14:38

Subtasks

Bug #40661: The PropertyMapper can still choke on compositeTypes like collection<entity>ResolvedMarc Neuhaus2012-12-25

Actions

Related issues

Related to TYPO3.Flow - Bug #39445: PropertyMapper chokes on Objects that are already converted inside an collectionResolvedMarc Neuhaus2012-12-25

Actions
Blocks Foo.ContentManagement - Major Feature #37293: Refactor Admin to work inside Phoenix as Foo.ContentManagementNew2012-05-18

Actions
#1

Updated by Marc Neuhaus about 9 years ago

Here's a little Patch to check if the source is an object and return it if it's an instance of the target type.

#2

Updated by Bastian Waidelich about 9 years ago

  • Subject changed from PropertyMapper chokes on Objects which are already in the target form to PropertyMapper chokes on Objects that are already converted
  • Category set to Property
  • Target version set to 1.1 beta 1
#3

Updated by Karsten Dambekalns about 9 years ago

  • Target version changed from 1.1 beta 1 to 1.1
#4

Updated by Karsten Dambekalns about 9 years ago

  • Target version changed from 1.1 to 1.1 RC1
#5

Updated by Sebastian Kurfuerst about 9 years ago

  • Status changed from New to Accepted
  • Priority changed from Should have to Must have
#6

Updated by Gerrit Code Review about 9 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11724

#7

Updated by Gerrit Code Review about 9 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11724

#8

Updated by Gerrit Code Review about 9 years ago

Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/12168

#9

Updated by Sebastian Kurfuerst about 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#10

Updated by Karsten Dambekalns about 9 years ago

  • Target version changed from 1.1 RC1 to 1.1 beta 3

Also available in: Atom PDF