Task #37558

Form.Textfield ViewHelper's placeholder attribute should be (re)moved

Added by Adrian Föder over 9 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Should have
Category:
ViewHelpers
Start date:
2012-05-29
Due date:
% Done:

100%

Estimated time:
Has patch:
No

Description

currently, the placeholder attribute in the Textfield ViewHelper is explicitly enabled:

code class="php">
    public function render($required = NULL, $type = 'text', $placeholder = NULL) {
        // [...]
        if ($placeholder !== NULL) {
            $this->tag->addAttribute('placeholder', $placeholder);
        }

For consistency, this part should either be completely removed and settable via additionalArguments or, alternatively, set as registerTagAttribute() in initializeArguments(). Of course we need to handle deprecation accordingly.

If you neither agree, than this should at least be reproduced in the textarea ViewHelper.


Related issues

Related to TYPO3.Fluid - Feature #37496: placeholder attribute in textarea-viewhelperClosed2012-05-25

Actions
Related to TYPO3.Fluid - Feature #55723: Support of schema.org attributesClosedBastian Waidelich2014-02-06

Actions
Has duplicate TYPO3.Fluid - Bug #48121: TextareaViewHelper is missing valid html5 argument placeholder ...Resolved2013-05-12

Actions
#1

Updated by Karsten Dambekalns almost 9 years ago

  • Target version changed from 2.0 beta 1 to 2.0
#2

Updated by Karsten Dambekalns over 8 years ago

  • Status changed from New to Accepted
  • Assignee set to Karsten Dambekalns
#3

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17684

#4

Updated by Karsten Dambekalns over 8 years ago

  • Target version changed from 2.0 to 2.1
#5

Updated by Karsten Dambekalns over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF