Bug #3994

Viewhelpers are instanciated multiple times in ViewHelperNode

Added by Bastian Waidelich about 13 years ago. Updated almost 12 years ago.

Status:
Resolved
Priority:
Must have
Category:
Core
Target version:
-
Start date:
2009-07-27
Due date:
% Done:

100%

Estimated time:
Has patch:

Description

In the evaluate() method of \F3\Fluid\Core\Parser\SyntaxTree\ViewHelperNode there is

$viewHelper = $objectFactory->create($this->viewHelperClassName);

The viewhelper should be stored in a private/protected field to be able to do

if ($this->viewHelper === NULL) {
    $this->viewHelper = $objectFactory->create($this->viewHelperClassName);
}

This will increase performance and make it possible to store private values in view helpers.


Related issues

Related to TYPO3.Fluid - Bug #4051: TagBuilder is not resetted when a view helper is initialized multiple timesResolvedBastian Waidelich2009-07-29

Actions
#1

Updated by Sebastian Kurfuerst about 13 years ago

  • Status changed from New to Accepted
  • Priority changed from Should have to Must have
#2

Updated by Sebastian Kurfuerst about 13 years ago

  • Status changed from Accepted to Resolved
  • % Done changed from 0 to 100

Applied in changeset r2895.

Also available in: Atom PDF