TYPO3.Flow

The controller:

  public function indexAction() {

    $this->view->assignMultiple(array(
      'companys' => $this->companyRepository->findByFilter($this->companyFilter),
      'companyFilter' => $this->companyFilter
      )
    ));

  }

($this->companyRepository->findByAll() is also effected, companyFilter is an SessionObject)

The findByFilter function:

  /**
   * @param \My\Package\Domain\Model\CompanyFilter $companyFilter
   * @return \TYPO3\FLOW3\Persistence\QueryResultInterface
   */
  public function findByFilter($companyFilter = NULL) {
    $query = $this->createQuery();
    $constraints = array();

    if ($companyFilter->getSearchWord()) {
      $constraints[] = $query->logicalOr(
        /* Here are some Likes */
      );
    }

    if ($companyFilter->getMyProperty()) {
      $constraints[] = $query->equals('myProperty.title', $companyFilter->getMyProperty());
    }

    if (count($constraints) > 0) $query->matching($query->logicalAnd($constraints));

    return $query->execute();
  }

The template:

<f:widget.paginate objects="{companys}" as="paginatedCompanys" configuration="{itemsPerPage: 10, insertAbove: 0, insertBelow: 1, maximumNumberOfLinks: 10}" widgetId="companyListPaginate">
  <table id="companyList">
    ...
    <f:if condition="{paginatedCompanys}">
      <f:then>
        <f:for each="{paginatedCompanys}" as="company" iteration="companyIterator">
      </f:then>
      <f:else>
        nothing to show
      </f:else>
    </f:if>
    ...
    </f:for>
    ...
  </table>
</f:widget.paginate>

On Page one it shows 10 items for <f:for each="{paginatedCompanys}">

On Page two and three I got the else function with "nothing to show".

With the count ViewHelper I got:

<f:widget.paginate objects="{companys}" as="paginatedCompanys" configuration="{itemsPerPage: 10, insertAbove: 0, insertBelow: 1, maximumNumberOfLinks: 10}" widgetId="companyListPaginate">
  {companys -> f:count()} => {paginatedCompanys ->f:count}
</f:widget.paginate>

Page one:

27 => 27

Page two:

27 => 0

Page three:

27 => 0

Hi,
thanks for the details.
I need to test this, but could you try the following for now:

<f:if condition="{companys}">
  <f:then>
    <f:widget.paginate objects="{companys}" as="paginatedCompanys" configuration="{itemsPerPage: 10, insertAbove: 0, insertBelow: 1, maximumNumberOfLinks: 10}" widgetId="companyListPaginate">
      <table id="companyList">
        ...
        <f:for each="{paginatedCompanys}" as="company" iteration="companyIterator">
           ...
        </f:for>
      </table>
    </f:widget.paginate>
  </f:then>
  <f:else>
      Nothing to show
   </f:else>
</f:if>

if {companys} is set, {paginatedCompanys} will always be set, too.

btw: it should be "companIEs" ;)

Okay, this variant seems to be working... but why? ^^

now I need to rewrite the paginate template ;)

thanks for you note about companIEs :)

Ok, the actual issue with this is that the Doctrine/QueryResult::count() throws an exception if the underlying query has an offset (which is the case for queries that have been modified through the pagination widget).
Internally the error happens in Doctrine\Query::count():

public function count() {
    try {
        $originalQuery = $this->queryBuilder->getQuery();
        $dqlQuery = clone $originalQuery;
        $dqlQuery->setParameters($originalQuery->getParameters());
        $dqlQuery->setHint(\Doctrine\ORM\Query::HINT_CUSTOM_TREE_WALKERS, array('TYPO3\Flow\Persistence\Doctrine\CountWalker'));
        return (int)$dqlQuery->getSingleScalarResult();
    } catch (\Doctrine\ORM\ORMException $ormException) {
        $this->systemLogger->logException($ormException);
        return 0;
    } catch (\PDOException $pdoException) {
        throw new DatabaseConnectionException($pdoException->getMessage(), $pdoException->getCode());
    }
}

Where the exception is caught and 0 is returned. If I reset the offset here with

$dqlQuery->setFirstResult(NULL);

it seems to work (even though counting on a query with limit will always count all results..)

Karsten Hachmeister can you verify this?

Bastian Waidelich wrote:

Karsten Hachmeister can you verify this?

Didn't try it, but it sounds reasonable. Whatever happens inside Doctrine there - resetting the offset for this case should not have any side effects.

Karsten Dambekalns wrote:

Didn't try it, but it sounds reasonable. Whatever happens inside Doctrine there
resetting the offset for this case should not have any side effects.

Thanks.
I could push a change set, but I just wonder if that behavior is correct at all:

$query->setLimit(10);
$query->setOffset(5);
$query->execute()->count(); // will throw away limit & offset

Probably the right way to do this would be to really count the results as soon as an offset is set and compare return max($numberOfRows, $limit)...

Bastian Waidelich wrote:

Probably the right way to do this would be to really count the results as soon as an offset
is set and compare return max($numberOfRows, $limit)...

This (rough) adjustment does this:

public function count() {
    try {
        $originalQuery = $this->queryBuilder->getQuery();
        $dqlQuery = clone $originalQuery;
        $dqlQuery->setParameters($originalQuery->getParameters());
        $dqlQuery->setHint(\Doctrine\ORM\Query::HINT_CUSTOM_TREE_WALKERS, array('TYPO3\Flow\Persistence\Doctrine\CountWalker'));
        $offset = $dqlQuery->getFirstResult();
        $limit = $dqlQuery->getMaxResults();
        if ($offset !== NULL) {
            $dqlQuery->setFirstResult(NULL);
        }
        $numberOfResults = (int)$dqlQuery->getSingleScalarResult();
        if ($offset !== NULL) {
            $numberOfResults = max(0, $numberOfResults - $offset);
        }
        if ($limit !== NULL) {
            $numberOfResults = min($numberOfResults, $limit);
        }
        return $numberOfResults;
    } catch (\Doctrine\ORM\ORMException $ormException) {
        $this->systemLogger->logException($ormException);
        return 0;
    } catch (\PDOException $pdoException) {
        throw new DatabaseConnectionException($pdoException->getMessage(), $pdoException->getCode());
    }
}

Patch set 2 for branch FLOW3-1.1 has been pushed to the review server.
It is available at https://review.typo3.org/17074