Bug #44174

Base Distribution - Work Package #45020: Content Editing Stability and Features

Removing image dimensions throws exception in AJAX response

Added by Soren Malling over 6 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
UI
Target version:
-
Start date:
2012-12-21
Due date:
% Done:

100%


Description

Removing dimensions, when inserting a image causes the AJAX response to throw a exception. ImageVariant can't take 0 or negative numbers.

This could somehow be handlede both in the inspector and/or in the ImageVariant class

Associated revisions

Revision b54b59cd (diff)
Added by Aske Ertmann over 6 years ago

[FEATURE] Improve handling of images in the inspector

Change-Id: I1fe94fc52e611d05eebc971889fa3d038af032d0
Fixes: #44174

Revision 4df2a619 (diff)
Added by Aske Ertmann over 6 years ago

[BUGFIX] Removing image dimensions throws exception

This is fixed by only adding resize processing
instructions if the width and height is more than 0.

Change-Id: I490002ac365888b9d9f8048e4ce62c319e9f1bf3
Fixes: #44174

History

#1 Updated by Mattias Nilsson over 6 years ago

Bugfix sent for review: https://review.typo3.org/17567

#2 Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17567

#3 Updated by Gerrit Code Review over 6 years ago

Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17692

#4 Updated by Aske Ertmann over 6 years ago

  • Parent task set to #45020

#5 Updated by Aske Ertmann over 6 years ago

  • Subject changed from Removing image dimensions throws exception in AJAX respinse to Removing image dimensions throws exception in AJAX response

#6 Updated by Gerrit Code Review over 6 years ago

Patch set 8 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17692

#7 Updated by Gerrit Code Review over 6 years ago

Patch set 9 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17692

#8 Updated by Gerrit Code Review over 6 years ago

Patch set 10 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17692

#9 Updated by Aske Ertmann over 6 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

#10 Updated by Aske Ertmann over 6 years ago

  • Status changed from Resolved to Accepted
  • Assignee set to Aske Ertmann
  • Priority changed from Should have to Must have
  • % Done changed from 100 to 80

This is still an issue.

#11 Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20170

#12 Updated by Aske Ertmann over 6 years ago

  • Status changed from Accepted to Under Review

#13 Updated by Aske Ertmann over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 80 to 100

#14 Updated by Aske Ertmann almost 5 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF