Bug #44889

Format urlencode viewhelper should work with objects that implement __toString

Added by Christian Müller over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2013-01-28
Due date:
% Done:

100%

Estimated time:
Has patch:
No

Description

currently a check for is_string prevents format.urlencode to work with objects that implements __toString

#1

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Accepted to Under Review

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17763

#2

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17763

#3

Updated by Christian Müller over 8 years ago

Note: This is the same in other format viewhelpers as well, so should probably be changed there as well to be consistent.

#4

Updated by Gerrit Code Review over 8 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17763

#5

Updated by Gerrit Code Review over 8 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17763

#6

Updated by Gerrit Code Review over 8 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17763

#7

Updated by Gerrit Code Review over 8 years ago

Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17763

#8

Updated by Gerrit Code Review over 8 years ago

Patch set 8 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17763

#9

Updated by Gerrit Code Review over 8 years ago

Patch set 9 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17763

#10

Updated by Gerrit Code Review over 8 years ago

Patch set 10 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17763

#11

Updated by Gerrit Code Review over 8 years ago

Patch set 11 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17763

#12

Updated by Sebastian Kurfuerst over 8 years ago

  • Status changed from Under Review to Resolved
#13

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/19137

#14

Updated by Robert Lemke over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF