Bug #46883

Custom identifiers are not working anymore

Added by Bastian Waidelich over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Must have
Category:
Persistence
Start date:
2013-04-03
Due date:
% Done:

100%

Estimated time:
PHP Version:
Has patch:
No
Complexity:

Description

https://review.typo3.org/#/c/18954/ introduced a regression that prevents entities with custom identifier columns to be working correctly.
The actual issue is probably, that the "PersistenceMagicAspect" introduces the "Persistence_Object_Identifier" even if the entity contains a custom identifier. By checking for that property first, PersistenceManager::getIdentifierByObject() will always return a UUID regardless of the actual identifier – breaking links and such.


Related issues

Related to TYPO3.Flow - Bug #43192: findByIdentifier() for non-persisted objects not working for custom identifier propertiesAcceptedKarsten Dambekalns2012-11-21

Actions
#1

Updated by Bastian Waidelich over 8 years ago

  • Subject changed from custom identifiers are not working anymore to Custom identifiers are not working anymore
#2

Updated by Bastian Waidelich over 8 years ago

  • Status changed from New to Accepted
  • Assignee set to Bastian Waidelich
#3

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19532

#4

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19532

#5

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19532

#6

Updated by Gerrit Code Review over 8 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19532

#7

Updated by Gerrit Code Review over 8 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19532

#8

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/19559

#9

Updated by Bastian Waidelich over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF