Task #48074

Neos backend no conflict mode

Added by Aske Ertmann over 8 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Must have
Assignee:
Category:
-
Target version:
Start date:
2013-05-08
Due date:
% Done:

100%

Estimated time:

Description

Currently the JavaScript for the Neos backend is not properly contained so it breaks when a page has its own version of jQuery or RequireJS. This needs to be fixed to allow using Neos with all kinds of templates.

RequireJS has already some support of loading things asynchronously and with different versions at the same time, which could probably be used to solve some of the issues.

#1

Updated by Aske Ertmann over 8 years ago

  • Assignee set to Adrian Föder

Hey Adrian

I believe you have some insight to this, could you maybe provide some more information about the issues you have experienced?

Thanks

#2

Updated by Christian Müller over 8 years ago

  • Status changed from New to Needs Feedback

We merged a big change that should improve this a lot. Please try if it is better for you, then we could close this issue for now.

#3

Updated by Adrian Föder over 8 years ago

sorry missed the assignment; my problem was that I already included require.js on my own, hence no backend at all was loaded. I assume this is a side-effect of requirejs because once it's loaded (the one I provided), it stops looking for data-main arguments anywhere, hence the one Neos provides.

#4

Updated by Aske Ertmann over 8 years ago

Just to be clear have you tried it again or? We improved a lot of the conflicts, but AFAIK RequireJS still conflicts. Most other JS frameworks shouldn't however.

#5

Updated by Adrian Föder over 8 years ago

I tried it and it's definitely not gone.

This is, IMO, a plain requireJS issue because I think requireJS starts itself as soon as it's executed, hence no further DOM loading happened. RequireJS then searches for the last <script> tag until that moment and finds out "its" script tag then.
Then it looks at the data-main attribute on that tag and starts its actual work.

When included manually, requireJS starts itself, does not find a relevant data-main attribute and does nothing. Later in the DOM building process, the neos-<script> with its data-main attribute is there, but the new loaded (neos) require.js does nothing because another require.js is already present.

#6

Updated by Aske Ertmann over 8 years ago

Will you try to have a go fixing this or should we assign this to Sebastian or Rens for a possible solution to the issue?

#7

Updated by Aske Ertmann over 8 years ago

  • Target version set to 1.0 beta 1
#8

Updated by Alexander Schnitzler about 8 years ago

Any update on this one? Beta1 is released so what's the plan here?

It sound's a little mean but I want to manage modern pages with Neos, not the ones I did in the late 90s. Don't take me too serious but this one is really an issue here.

I just opened another bug report as this error also occures with foundation 5 now. Cannot exactly say who is to blame here but I cannot turn off my local js everytime I want to edit my content. Though, being able to sell this, I would be rich a lot sooner. ;-)

#9

Updated by Gerrit Code Review almost 8 years ago

  • Status changed from Needs Feedback to Under Review

Patch set 5 for branch master of project Packages/TYPO3.Neos has been pushed to the review server.
It is available at https://review.typo3.org/26487

#10

Updated by Gerrit Code Review almost 8 years ago

Patch set 6 for branch master of project Packages/TYPO3.Neos has been pushed to the review server.
It is available at https://review.typo3.org/26487

#11

Updated by Gerrit Code Review over 7 years ago

Patch set 7 for branch master of project Packages/TYPO3.Neos has been pushed to the review server.
It is available at https://review.typo3.org/26487

#12

Updated by Rens Admiraal over 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Applied in changeset commit:856803b48053815be74706044477cbae6f850e27.

Also available in: Atom PDF