Bug #48887

Support numeric identifiers in IdentityRoutePart

Added by Christopher Hlubek over 6 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Must have
Category:
MVC - Routing
Target version:
-
Start date:
2013-06-05
Due date:
% Done:

100%

PHP Version:
Has patch:
No
Complexity:

Description

In \TYPO3\Flow\Mvc\Routing\ObjectPathMappingRepository::findOneByObjectTypeUriPatternAndIdentifier the identifier of an object is checked to be exactly of type string. This should be changed to check for simple types that can be coerced to a string. Basically we need to support numeric values additionally to strings here.


Related issues

Related to TYPO3.Flow - Bug #58517: Integer arent allowed as object identifier in routes Resolved 2014-05-05

Associated revisions

Revision 4e698ac3 (diff)
Added by Bastian Waidelich over 4 years ago

[BUGFIX] Support numeric identifiers in dynamic route parts

Currently the dynamic route part handler provided by Flow (namely
``DynamicRoutePart`` and ``IdentityRoutePart``) only support objects
with string identifiers.

With this change also numeric identifiers are supported, for example
for entities with a numeric auto_increment identifier.

Change-Id: I57da5820c38d08494937f011439c00b0fd6851a7
Fixes: #48887
Fixes: #58517
Releases: master, 2.3, 2.2

Revision f5bb0553 (diff)
Added by Bastian Waidelich over 4 years ago

[BUGFIX] Support numeric identifiers in dynamic route parts

Currently the dynamic route part handler provided by Flow (namely
``DynamicRoutePart`` and ``IdentityRoutePart``) only support objects
with string identifiers.

With this change also numeric identifiers are supported, for example
for entities with a numeric auto_increment identifier.

Change-Id: I57da5820c38d08494937f011439c00b0fd6851a7
Fixes: #48887
Fixes: #58517
Releases: master, 2.3, 2.2

Revision 8687bfb8 (diff)
Added by Bastian Waidelich over 4 years ago

[BUGFIX] Support numeric identifiers in dynamic route parts

Currently the dynamic route part handler provided by Flow (namely
``DynamicRoutePart`` and ``IdentityRoutePart``) only support objects
with string identifiers.

With this change also numeric identifiers are supported, for example
for entities with a numeric auto_increment identifier.

Change-Id: I57da5820c38d08494937f011439c00b0fd6851a7
Fixes: #48887
Fixes: #58517
Releases: master, 2.3, 2.2

History

#1 Updated by Bastian Waidelich over 6 years ago

FYI: I'm currently tweaking the IdentityRoutePart handler to support following "features":

  • Respect "toLowerCase" flag (#44521)
  • Disable lookup table (for unique properties like Id or UUID)
  • Proper transliteration (using I18N package)

But it probably won't make it into 2.0 any longer

#2 Updated by Bastian Waidelich over 5 years ago

  • Status changed from New to Accepted
  • Assignee changed from Christopher Hlubek to Bastian Waidelich

I lost track of this one.. But I'm on it now

#3 Updated by Gerrit Code Review over 5 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at https://review.typo3.org/30116

#4 Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at https://review.typo3.org/30116

#5 Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at http://review.typo3.org/30116

#6 Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch 2.3 of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at http://review.typo3.org/36997

#7 Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch 2.2 of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at http://review.typo3.org/36998

#8 Updated by Bastian Waidelich over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#9 Updated by Gerrit Code Review over 4 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 2.2 of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at http://review.typo3.org/36998

#10 Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch 2.2 of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at http://review.typo3.org/36998

#11 Updated by Bastian Waidelich over 4 years ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF