Feature #50657

rsync transfer method: add option the --exclude argument

Added by Tobias Liebig over 6 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Won't have this time
Assignee:
-
Target version:
-
Start date:
2013-08-01
Due date:
% Done:

0%


Description

add an exclude option for rsync task (--exclude arguments)

History

#1 Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24306

#2 Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24306

#3 Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24306

#4 Updated by Gerrit Code Review over 6 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24306

#5 Updated by Andreas Dörler over 5 years ago

Hi,

this patch looks good to me. We're using something similar to exclude files and folders from rsync.

There is just one little thing, which should be changed imho:

$excludeFlags[] = '--exclude \'' . escapeshellarg($exclude) . '\'';

escapeshellarg automatically adds quotes, so there is no need for the extra \'

It'd be great to have this very useful patch integrated.

Kind regards
Andreas

#6 Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 5 for branch master of project Packages/TYPO3.Surf has been pushed to the review server.
It is available at https://review.typo3.org/24306

#7 Updated by Lars Malach over 5 years ago

Thanks Andreas for the hint.. I updated the patch..

Best, Lars

#8 Updated by Helmut Hummel about 4 years ago

  • Status changed from Under Review to Resolved
  • Priority changed from Should have to Won't have this time

The task has the possibility to exchange the rsync flags already. this should be enough for the advanced cases.

Development of TYPO3 Surf now moved to Github. If you think this is still relevant, please open a bug report or feature request here:

https://github.com/TYPO3/Surf

Also available in: Atom PDF