Bug #50779

Handling of branch option in GitCheckout Task does not work as expected.

Added by Martin Ficzel over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Must have
Assignee:
Target version:
-
Start date:
2013-08-05
Due date:
% Done:

100%

Estimated time:

Description

Since the last updates the prevoiusly used option "git-checkout-branch" is replaced by "typo3.surf:gitcheckout[branch]" and the option is remapped internally to the new key.

The code in the AbstractCheckoutTask->resolveSha1 is using the key "branch" in the option array that is handed over by the taskManager.

The deployment is running but since the option is not read as expected the deployment will always fallback to the master branch unless the global "branch" option is set. Since this is not what surf itself says can cause serious trouble.

#1

Updated by Martin Ficzel over 8 years ago

To me it looks like an incomplete merge. Is it possible that a change in the option handling was not included in the commit or is still in the review-process?

#2

Updated by Martin Ficzel over 8 years ago

I found the reason for the problem.

Option "git-checkout-branch" is deprecated and will be removed before Surf 1.0.0. Set option "typo3.surf:gitcheckout[branch]" instead.

The depercation message is misleading since the mentioned option "typo3.surf:gitcheckout[branch]" must be written in CamelCase as "typo3.surf:gitCheckout[branch]" to have an effect.

So i think this is mostly a documentation bug.

#3

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22837

#4

Updated by Anonymous over 8 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF