Handling of branch option in GitCheckout Task does not work as expected.
Since the last updates the prevoiusly used option "git-checkout-branch" is replaced by "typo3.surf:gitcheckout[branch]" and the option is remapped internally to the new key.
The code in the AbstractCheckoutTask->resolveSha1 is using the key "branch" in the option array that is handed over by the taskManager.
The deployment is running but since the option is not read as expected the deployment will always fallback to the master branch unless the global "branch" option is set. Since this is not what surf itself says can cause serious trouble.
Updated by Martin Ficzel over 8 years ago
I found the reason for the problem.
Option "git-checkout-branch" is deprecated and will be removed before Surf 1.0.0. Set option "typo3.surf:gitcheckout[branch]" instead.
The depercation message is misleading since the mentioned option "typo3.surf:gitcheckout[branch]" must be written in CamelCase as "typo3.surf:gitCheckout[branch]" to have an effect.
So i think this is mostly a documentation bug.