TYPO3.Fluid

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22839

Hi Bastian; how would you do that with the patch you've mentioned?

Adrian Föder wrote:

Hi Bastian; how would you do that with the patch you've mentioned?

Create a Views.yaml and override the default layoutRootPath:

    -
      options:
        layoutRootPath: 'resource://Some.Package/Private/Layouts'

If you only want to override it for certain packages/controllers/actions you can use the requestPattern configuration

Hi Bastian,

i see no opposites to using both patches for that. #50801 and #50826 are backward compatible to current Fluid and i think it is similarly compatible to #42176.

Hi Bastian again,

but still with Views.yaml you can only set the path, not the complete "url" to the file.
Consider a use case where you have a Neos Site Package and a plain Flow package and you want to cross-reference concrete partial files, for example, just to avoid duplicate template code.

Rafael Kähm wrote:

i see no opposites to using both patches for that.

The patches are compatible, yes. But we prefer a single way of configuration and I can't think of a scenario that is possible with this patch but not with the Views.yaml change

Adrian Föder wrote:

but still with Views.yaml you can only set the path, not the complete "url" to the file.

Of course:

     -
       requestFilter: 'isPackage("Original.Package") && isController("Foo") && isAction("bar")'
       options:
         partialPathAndFilenamePattern: 'resource://Some.Package/Private/Partials/Foo.html'

Or did I get you wrong?

I agree, setting "path"/"package" on the layout view helper is simpler for that use case. But with the views configuration we have one way of covering all sorts of scenarios.

Adrian Föder wrote:

Bastian, for the mentioned configuration you will force-overwrite the whole partial path and file name

Yes, you're right. This probably makes more sense with layouts. However with the "Fallback path" feature (#39870) it should be possible to do something like:

     -
       requestFilter: 'isPackage("Original.Package") && isController("Foo") && isAction("bar")'
       options:
         partialRootPaths: ['resource://Some.Package/Private/Partials/', 'resource://Original.Package/Private/Partials/']

I really don't want to be too restrictive and maybe I'm missing something, but I really fear Fluid getting too complex (code and usage-wise). Let's see what others think about this