Bug #51302

Node with object has property break PluginImplementation

Added by Dominique Feyer about 6 years ago. Updated about 6 years ago.

Status:
Resolved
Priority:
Should have
Category:
-
Target version:
-
Start date:
2013-08-23
Due date:
% Done:

100%


Description

Currently Neos PluginImplementation use the Request argument to pass the node properties. This work fine for simple type, but break with object. By using internal arguments, object can be passed with success.

This is a breaking change.

Associated revisions

Revision 78055b9f (diff)
Added by Dominique Feyer about 6 years ago

[!!!][BUGFIX] Node with object property breaks PluginImplementation

Currently Neos PluginImplementation use the Request argument to pass the
node properties. This work fine for simple type, but break with object.
By using internal arguments, object can be passed with success.

This is a breaking change.

Change-Id: Ia2855efe4fd5c5aeb4515ae8ceb920f2d366de53
Resolves: #51302
Releases: master
Reviewed-on: https://review.typo3.org/23279
Reviewed-by: Dominique Feyer
Tested-by: Dominique Feyer
Reviewed-by: Sebastian Kurfuerst
Tested-by: Sebastian Kurfuerst

History

#1 Updated by Gerrit Code Review about 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23279

#2 Updated by Gerrit Code Review about 6 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23279

#3 Updated by Gerrit Code Review about 6 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23279

#4 Updated by Dominique Feyer about 6 years ago

  • Subject changed from PluginImplementation must handle argument has request internal argument to Node with object has property break PluginImplementation

#5 Updated by Gerrit Code Review about 6 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23279

#6 Updated by Gerrit Code Review about 6 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23279

#7 Updated by Gerrit Code Review about 6 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23279

#8 Updated by Dominique Feyer about 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF