Bug #56598

Absolute URI for WebEntry

Added by Frederik Vosberg over 7 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Should have
Category:
Security
Target version:
-
Start date:
2014-03-06
Due date:
% Done:

100%

Estimated time:
PHP Version:
Has patch:
Yes
Complexity:

Description

Hi,

I tried to configure an absolute URL for my entry point of a security provider. But it can't handle the absolute uri.

provider: MyProvider
entryPoint: 'WebRedirect'
entryPointOptions:
uri: http://www.absolute-url.de/

I have created a patch.

Flow version: 2.1.1


Files

bugfix-abs-uri-entry-point.diff (1.59 KB) bugfix-abs-uri-entry-point.diff Frederik Vosberg, 2014-03-06 13:00
#2

Updated by Bastian Waidelich over 7 years ago

  • Status changed from New to Needs Feedback
  • Assignee set to Bastian Waidelich
  • Priority changed from Must have to Should have

FYI: The "uri" option of the WebRedirect entry point is deprecated. See http://docs.typo3.org/flow/TYPO3FlowDocumentation/TheDefinitiveGuide/PartIII/Security.html#authentication-entry-points

Can you please explain why you need an absolute URI here?

#3

Updated by Frederik Vosberg over 7 years ago

Because I want to redirect to an external URL. And the way through a controller would be too much. Is there another way?

#4

Updated by Bastian Waidelich over 7 years ago

  • Category set to Security
  • Status changed from Needs Feedback to Accepted

Frederik Vosberg wrote:

Because I want to redirect to an external URL. And the way through a controller would be too much. Is there another way?

Fair enough, but we should detect absolute URIs using parse_url() (like we do it in other places, for instance https://git.typo3.org/Packages/TYPO3.Fluid.git/blob/HEAD:/Classes/TYPO3/Fluid/ViewHelpers/Link/ExternalViewHelper.php#l65)
I'll take care of this

#5

Updated by Gerrit Code Review over 7 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at https://review.typo3.org/30117

#6

Updated by Bastian Waidelich over 7 years ago

I finally got around pushing this one. Sorry, I didn't know that this feature was already (incorrectly) implemented. I didn't look at your patch and thought this was a new "feature"..

#7

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at https://review.typo3.org/30117

#8

Updated by Bastian Waidelich over 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#9

Updated by Gerrit Code Review over 7 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 2.2 of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at https://review.typo3.org/30428

#10

Updated by Bastian Waidelich over 7 years ago

  • Status changed from Under Review to Resolved
#11

Updated by Gerrit Code Review over 7 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 2.1 of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at https://review.typo3.org/30837

#12

Updated by Bastian Waidelich over 7 years ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF