Bug #8913

Unit test failures because sys_get_temp_dir() doesn't always return directory name with trailing slash

Added by Christian Kuhn over 10 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
Must have
Category:
- Testing -
Start date:
2010-07-17
Due date:
% Done:

100%

Estimated time:
PHP Version:
Has patch:
Complexity:

Description

php function sys_get_temp_dir() usually returns something like '/tmp/', but on some systems the trailing slash is missing (for me: a debian stable box, self compiled php 5.3.2, running as cgi). This leads to failing tests, eg. in Cache\Backend\PdoBackendTest

This could be easily fixed by always adding a slash (see attached patch), but leads to double slashes if the method returns with trailing slash.

Maybe it would be better to add / use some wrapper method to add the slash if it's missing?


Files

sys_get_temp_dir.diff (4.5 KB) sys_get_temp_dir.diff Christian Kuhn, 2010-07-17 01:35
#1

Updated by Bastian Waidelich over 10 years ago

  • Status changed from New to Accepted
  • Assignee set to Bastian Waidelich
  • Priority changed from Should have to Must have

Thanks for your feedback! Such function already exists in Utility\Files. I'll take care of this!

#2

Updated by Andreas Förthner over 10 years ago

  • Assignee changed from Bastian Waidelich to Andreas Förthner
  • Target version set to 1.0 alpha 11
#3

Updated by Andreas Förthner over 10 years ago

  • Status changed from Accepted to Resolved
  • % Done changed from 0 to 100

Applied in changeset r4921.

Also available in: Atom PDF