Bug #102268: TypoScript conditions for tree.pagelayout do not work correctly on page level 1 - TYPO3 Core - TYPO3 Forge

Custom queries

12 LTS
Accessibility
Dashboard issues
Easy tasks
Extbase Issues
FAL Issues
FAL Sprint 2023
Hierarchical Issues
Issues reported for v11
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
Most wanted Bugfixes
Most wanted Features
My open issues
New & Unassigned
No feedback within 90 days
Open Bugs
Open issues of 10
Page Tree Regressions after 2020-07-28
Recently modified
Regressions
Stabilization Issues
Usability or UX

Watchers (1)

Stig Nørgaard Færch

Actions

Copy link

Bug #102268

closed

TypoScript conditions for tree.pagelayout do not work correctly on page level 1

Added by Stig Nørgaard Færch 7 months ago. Updated 3 months ago.

Status:

Resolved

Priority:

Should have

Assignee:

Category:

TypoScript

Target version:

Candidate for patchlevel

Start date:

2023-10-27

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

8.1

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

The pagelayout is not resolved correctly.

To recreate, create a rootline with 4 pages like this:

<?php
$rootLine = [
    [
        'backend_layout_next_level' => 'pagets__default', // Level 0 / TypoScript root template page
    ],
    [
        'backend_layout_next_level' => 'pagets__default', // Level 1
    ],
    [
        'backend_layout_next_level' => '',  // Level 2
    ],
    [
        'backend_layout_next_level' => '',  // Level 3
    ],
];

Add the condition:

[tree.pagelayout == "pagets__default"]
    page.10 = TEXT
    page.10.value = It works!
[else]
    page.10 = TEXT
    page.10.value = It doesn't work :(
[end]

Open the level 1 page. It doesn't work.
Open the level 2 page. It works.
Open the level 3 page. It works.

Related issues 5 (0 open — 5 closed)

Related to TYPO3 Core - Bug #100764: TS condition does not work

Resolved

2023-04-26

Actions

Related to TYPO3 Core - Task #100047: Modernize condition matching / expression handling

Closed

2023-02-28

Actions

Related to TYPO3 Core - Bug #98044: TypoScript conditions for tree.pagelayout do not work correctly

Closed

2022-07-28

Actions

Related to TYPO3 Core - Feature #97816: New TypoScript parser

Closed

2022-06-27

Actions

Has duplicate TYPO3 Core - Bug #102890: array_reverse rootline for PageLayoutResolver::getLayoutForPage calls

Closed

2024-01-22

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Stig Nørgaard Færch 7 months ago

I found the reason. The $rootLine array can both be sorted ascending and descending depending where it comes from. In TSFE context it is sorted descending, and array_shift will then remove the current page.
But in the context of the condition matcher, the sorting is in opposite direction, and the consequence is that the value from backend_layout_next_level is not found from the root page, as it has been removed from the rootline.

I propose to insert a krsort($rootLine) before array_shift($rootLine)

    public function getLayoutForPage(array $page, array $rootLine): string
    {
        $selectedLayout = $page['backend_layout'] ?? '';

        // If it is set to "none" - don't use any
        if ($selectedLayout === '-1') {
            return 'none';
        }

        if ($selectedLayout === '' || $selectedLayout === '0') {
            // If it not set check the root-line for a layout on next level and use this
            // Remove first element, which is the current page
            // See also \TYPO3\CMS\Backend\View\BackendLayoutView::getSelectedCombinedIdentifier()
            krsort($rootLine); // <-- Add to ensure the rootline is always sorted as descending, so it's always the current page that is removed, and not the root page
            array_shift($rootLine);

Actions

Copy link

Updated by Stig Nørgaard Færch 7 months ago

https://forge.typo3.org/issues/98044

Actions

Copy link

Updated by Stig Nørgaard Færch 7 months ago

Will try to push a commit.

Actions

Copy link

Updated by Gerrit Code Review 7 months ago

Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81595

Actions

Copy link

Updated by Gerrit Code Review 7 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81595

Actions

Copy link

Updated by Gerrit Code Review 7 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81595

Actions

Copy link

Updated by Nikita Hovratov 4 months ago

Related to Bug #100764: TS condition does not work added

Actions

Copy link

Updated by Nikita Hovratov 4 months ago

Related to Bug #102890: array_reverse rootline for PageLayoutResolver::getLayoutForPage calls added

Actions

Copy link

Updated by Nikita Hovratov 4 months ago

Related to Task #100047: Modernize condition matching / expression handling added

Actions

Copy link

#10

Updated by Nikita Hovratov 4 months ago

Related to deleted (Bug #102890: array_reverse rootline for PageLayoutResolver::getLayoutForPage calls)

Actions

Copy link

#11

Updated by Nikita Hovratov 4 months ago

Has duplicate Bug #102890: array_reverse rootline for PageLayoutResolver::getLayoutForPage calls added

Actions

Copy link

#12

Updated by Gerrit Code Review 4 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82560

Actions

Copy link

#13

Updated by Gerrit Code Review 4 months ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82560

Actions

Copy link

#14

Updated by Gerrit Code Review 4 months ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82560

Actions

Copy link

#15

Updated by Gerrit Code Review 4 months ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82560

Actions

Copy link

#16

Updated by Gerrit Code Review 4 months ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82560

Actions

Copy link

#17

Updated by Gerrit Code Review 4 months ago

Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82560

Actions

Copy link

#18

Updated by Christian Kuhn 3 months ago

Related to Bug #98044: TypoScript conditions for tree.pagelayout do not work correctly added

Actions

Copy link

#19

Updated by Christian Kuhn 3 months ago

Related to Feature #97816: New TypoScript parser added

Actions

Copy link

#20

Updated by Gerrit Code Review 3 months ago

Patch set 10 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82560

Actions

Copy link

#21

Updated by Gerrit Code Review 3 months ago

Patch set 11 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82560

Actions

Copy link

#22

Updated by Gerrit Code Review 3 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82743

Actions

Copy link

#23

Updated by Gerrit Code Review 3 months ago

Patch set 2 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82743

Actions

Copy link

#24

Updated by Dimitri König 3 months ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset f8fd9ecd7dd041aef3d9b6fd2b290f133be93419.

Actions

Copy link

Also available in: Atom PDF

Project

General

Profile

TYPO3 Core

Custom queries

Watchers (1)

Bug #102268

TypoScript conditions for tree.pagelayout do not work correctly on page level 1

Updated by Stig Nørgaard Færch 7 months ago

Updated by Stig Nørgaard Færch 7 months ago

Updated by Stig Nørgaard Færch 7 months ago

Updated by Gerrit Code Review 7 months ago

Updated by Gerrit Code Review 7 months ago

Updated by Gerrit Code Review 7 months ago

Updated by Nikita Hovratov 4 months ago

Updated by Nikita Hovratov 4 months ago

Updated by Nikita Hovratov 4 months ago

Updated by Nikita Hovratov 4 months ago

Updated by Nikita Hovratov 4 months ago

Updated by Gerrit Code Review 4 months ago

Updated by Gerrit Code Review 4 months ago

Updated by Gerrit Code Review 4 months ago

Updated by Gerrit Code Review 4 months ago

Updated by Gerrit Code Review 4 months ago

Updated by Gerrit Code Review 4 months ago

Updated by Christian Kuhn 3 months ago

Updated by Christian Kuhn 3 months ago

Updated by Gerrit Code Review 3 months ago

Updated by Gerrit Code Review 3 months ago

Updated by Gerrit Code Review 3 months ago

Updated by Gerrit Code Review 3 months ago

Updated by Dimitri König 3 months ago