Bug #11972: Switching workspace with tabs is different to switch ws in toolbar menu - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #11972

closed

Switching workspace with tabs is different to switch ws in toolbar menu

Added by Steffen Kamper over 13 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Susanne Moog

Category:

Workspaces

Target version:

Start date:

2011-01-06

Due date:

% Done:

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

When i switch ws in toolbar, the selection of modulemenu and pagetree remain. When i switch with tab click, selection of module menu and page tree are cleared.

Files

Download all files

moduleMenuRefresh_core.diff (1.34 KB) moduleMenuRefresh_core.diff		Susanne Moog, 2011-01-16 17:26
updateModuleMenu.diff (591 Bytes) updateModuleMenu.diff		Susanne Moog, 2011-01-16 17:26
11972_v2.diff (509 Bytes) 11972_v2.diff		Susanne Moog, 2011-01-19 10:42

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Tolleiv Nietsch over 13 years ago

Status changed from New to Accepted
Assignee set to Steffen Kamper
Target version set to 4.5 RC1

Actions

Copy link Download all files

Updated by Susanne Moog over 13 years ago

File moduleMenuRefresh_core.diff moduleMenuRefresh_core.diff added
File updateModuleMenu.diff updateModuleMenu.diff added

Attached two patches (1 core, 1 workspaces) with which this one is solved. What do you think? (BTW I can only reproduce the module menu issue)

Actions

Copy link

Updated by Tolleiv Nietsch over 13 years ago

great

+1 by reading and testing

Actions

Copy link

Updated by Susanne Moog over 13 years ago

Assignee changed from Steffen Kamper to Susanne Moog

RFC is pending in core list.

Actions

Copy link

Updated by Susanne Moog over 13 years ago

Status changed from Accepted to Under Review

Actions

Copy link

Updated by Sonja Schubert over 13 years ago

I tested the patches and basically they worked. I found one small bug that when I switch from one custome stage to another it does update the module menu but it becomes cleared. Do you have the same?

Switching from live to custom workspace and the other way round works fine and module menu and page tree are updated fine with the selection remained.

Actions

Copy link

Updated by Susanne Moog over 13 years ago

File 11972_v2.diff 11972_v2.diff added

I can reproduce Sonjas behaviour and thought a bit about it. Then I realized that I'm trying to fix this on the wrong end. We should not try to update the module menu, because the module menu should not change when I switch a workspace in the workspaces menu. So why does it change? That brought me to the patch v2. For some reason (probably a leftover) the module menu store was loaded on a workspace switch, causing it to reload too early and forgetting where it was.

So please test the attached patch :)

Actions

Copy link