TYPO3 Core

Category:

Linkvalidator

Target version:

Start date:

2011-01-14

Due date:

% Done:

100%

Estimated time:

(Total: 0.00 h)

PHP Version:

Tags:

Complexity:

Sprint Focus:

Description

This takes care of most external link issues.

We still need to wait for the patch for getUrl, but this should be solved soon.

add user-agent #13800
correct handling of location (Thanks to Daniel Minder)
move code up and down
remove useless or duplicated code

Files

Download all files

linkval-cleanup.diff (4.29 KB) linkval-cleanup.diff		Philipp Gampe, 2011-03-12 17:08
linkval-cleanup_2.diff (4.35 KB) linkval-cleanup_2.diff		Philipp Gampe, 2011-03-14 23:41
linkval-user-agent-cleanup-external-url.diff (4.33 KB) linkval-user-agent-cleanup-external-url.diff	without cookie support and without head only	Philipp Gampe, 2011-05-21 14:24

Subtasks 4 (0 open — 4 closed)

Feature #13794: Redirects in external links should observer Cookies

Closed

2011-03-11

Feature #13800: Add user-agent header

Closed

2011-03-12

Bug #13432: 404 for external links with no redirect

Closed

2011-02-28

Bug #12225: External Links with Redirects are reported as 404

Closed

2011-01-14

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Bug #13756: External links to big files crash TYPO3

Closed

2011-03-10

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Updated by Philipp Gampe about 13 years ago

File deleted (~~linkval-cleanup.diff~~)

Actions

Updated by Philipp Gampe about 13 years ago

File linkval-cleanup.diff added

I will commit in 48 hours if nobody objects.

Actions

Updated by Chris topher about 13 years ago

Hi Philipp,

do we need the line t3lib_utility_Debug::debug($cookies);?

The rest looks fine.

Actions

Updated by Philipp Gampe about 13 years ago

No, of course not ...

I am currently rewriting the whole loop and I will come up with a patch. It will cover all open issues regarding external link handling.

Actions

Updated by Philipp Gampe about 13 years ago

Subject changed from Cleanup external link, do not follow senseless loop to Cleanup external link, do not follow senseless loop, add user agent and cookies

Actions

Updated by Philipp Gampe about 13 years ago

File linkval-cleanup.diff linkval-cleanup.diff added
% Done changed from 0 to 80

Actions

Updated by Philipp Gampe about 13 years ago

File deleted (~~linkval-cleanup.diff~~)

Actions

Updated by Philipp Gampe about 13 years ago

I updated the patch ... please test.

Actions

Updated by Philipp Gampe about 13 years ago

File linkval-cleanup_2.diff linkval-cleanup_2.diff added

some code style cleanups
add getUrl($url, 3, FALSE, &$report) [needs fix in core]

Actions

#10

Updated by Philipp Gampe about 13 years ago

Subject changed from Cleanup external link, do not follow senseless loop, add user agent and cookies to Refactor external link, do not follow senseless loop, add user agent and cookies

Actions

#11

Updated by Daniel Minder about 13 years ago

I tested the patch (with getUrl($url, 2, ...) instead of 3) and found a bug in the Cookie handling.

It's not required that a path is given, and if it's present it does not need to be the first attribute. So, line 117 should be changed to:

if ((preg_match('/Set-Cookie: ([^;]+)/', $line, $cookie))) {

since the actual cookie stops at ; or at the end of the line. I'm not sure if the name or value of the cookie can be a quoted string that includes ;. http://tools.ietf.org/html/draft-ietf-httpstate-cookie-21 defines name and value to be a token as defined in RFC 2616 where token is "1*<any CHAR except CTLs or separators>". Then, the regexp would become more complex...

Actions

#12

Updated by Philipp Gampe about 13 years ago

A Cookie an also have an expires entry.

I think Name= + value + expires + ; + path is pretty much standard.

I will do some tests this afternoon.

Actions

#13

Updated by Philipp Gampe almost 13 years ago

Subject changed from Refactor external link, do not follow senseless loop, add user agent and cookies to Refactor external link, do not follow senseless loop, add user agent

Actions