TYPO3 Core

I think the code is just the wrong way around. It should first remove hidden pages and then get the uids of the content elements. Obviously hidden(=disabled) stuff should not be checked.

Maybe, extGetTreeList() should already filter out hidden pages. Nevertheless, this solves only half of the problem. For TV, we have to parse the TV XML data to find out which tt_content records are actually used...

Daniel Minder wrote:

Nevertheless, this solves only half of the problem. For TV, we have to parse the TV XML data to find out which tt_content records are actually used...

TV is out of scope of TYPO3 core and core does not care about TV! Storing this data in XML is bad design and there is no reason to add TV complexity to core.

If you come up with an "easy" patch, this might go into linkvalidator, but the better solution would be to create an extension which adds a new method to check TV content.
You can then disable normal internal checking.

Maybe we need to further split link checking methods (pages, content elements, etc.), but this would be a different issue.

Right, TV is not in core. But it was already discussed 5 years ago to move it there... But we have to admit that TV is widely used, regardless if storing page structure in XML is bad design or not.

I'm fine with putting the TV checking stuff to an extra extension, but linkvalidator has to provide hooks to make this possible.

Still no feedback

anyone?

I see if I can test tomorrow ... do you have a test extension? (You can try to nag me on Skype tomorrow ... this might help for faster reviews :D)

Shouldn't we remove those commented lines?

Yes comented code is useless in my opinion

Validation for internal pages works now fine for the website where it failed before (the one from the report above). Checked it on a second installation that was fine before - and still is fine :) Thanks for the patch!

The committed change seems to have opened a discussion in https://review.typo3.org/2288, where a reviewer points into this part of the code makes the statistic of broken links go mad (displaying "2" instead of "1").

So currently we cannot merge the "whole commit" and its sad because we wanted to include these fixes in 4.5.3 (to be released tomorrow morning). Anyone capable of solving that and resubmitting something working until tomorrow? :)

Thanks!

Please re-check https://review.typo3.org/2288 and patch set 4. I will send you a patch with the CGL fixes applied during this review, so that they can be applied to your external repository also (which we will migrate from SVN to GIT submodule afterwards).