Bug #16531
wizard_table.php - // FIXME what is $tLines? See wizard_forms.php for the same.
| Status: | Resolved | Start date: | 2006-09-06 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assignee: | Alexander Opitz | % Done: | 100% |
|
| Category: | - | |||
| Target version: | 6.2.0 | |||
| TYPO3 Version: | 6.2 | Complexity: | ||
| PHP Version: | ||||
| Votes: | 0 |
Description
Hi,
i found that line
// FIXME what is $tLines? See wizard_forms.php for the same.
at line 337 in typo3/wizard_table.php
i found it too in: typo3_src-4.0.2-rc1.tar.gz
// FIXME what is $tLines? See wizard_forms.php for the same.
if (($k+1)!=count($tLines)) {
// it should be:
if (($k+1)!=count($cfgArr)) {
than the last row have an "to top" button, instead of row_down
i didnt check wizard_forms.php
(issue imported from #M4164)
Associated revisions
[BUGFIX] Fix last line in table wizard
In the table wizard (table ce) you have the possibility to move first line
to the last line and vice versa. But on last line the false icon and
input field is set. We also have a FIXME comment there.
With the patch we fix the problem and you can again move the last line on
top of the lines.
Resolves: #16531
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I7fe69397ba595a6b2aec8cdfba05b286f3b8ebe4
Reviewed-on: https://review.typo3.org/20455
Reviewed-by: Simon Schaufelberger
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
[BUGFIX] Fix last line in table wizard
In the table wizard (table ce) you have the possibility to move first line
to the last line and vice versa. But on last line the false icon and
input field is set. We also have a FIXME comment there.
With the patch we fix the problem and you can again move the last line on
top of the lines.
Resolves: #16531
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I7fe69397ba595a6b2aec8cdfba05b286f3b8ebe4
Reviewed-on: https://review.typo3.org/20918
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
[BUGFIX] Fix last line in table wizard
In the table wizard (table ce) you have the possibility to move first line
to the last line and vice versa. But on last line the false icon and
input field is set. We also have a FIXME comment there.
With the patch we fix the problem and you can again move the last line on
top of the lines.
Resolves: #16531
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I7fe69397ba595a6b2aec8cdfba05b286f3b8ebe4
Reviewed-on: https://review.typo3.org/20918
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-on: https://review.typo3.org/20920
[BUGFIX] Fix last line in table wizard
In the table wizard (table ce) you have the possibility to move first line
to the last line and vice versa. But on last line the false icon and
input field is set. We also have a FIXME comment there.
With the patch we fix the problem and you can again move the last line on
top of the lines.
Resolves: #16531
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I7fe69397ba595a6b2aec8cdfba05b286f3b8ebe4
Reviewed-on: https://review.typo3.org/20921
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
[BUGFIX] Fix last line in table wizard
In the table wizard (table ce) you have the possibility to move first line
to the last line and vice versa. But on last line the false icon and
input field is set. We also have a FIXME comment there.
With the patch we fix the problem and you can again move the last
line on top of the lines.
Resolves: #16531
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I7fe69397ba595a6b2aec8cdfba05b286f3b8ebe4
Reviewed-on: https://review.typo3.org/20922
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
History
Updated by Gerrit Code Review 18 days ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20455
Updated by Alexander Opitz 18 days ago
- Assignee set to Alexander Opitz
- Target version changed from 0 to 6.2.0
- TYPO3 Version changed from 4.0 to 6.2
- PHP Version deleted (
4)
Updated by Gerrit Code Review 8 days ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20455
Updated by Gerrit Code Review 2 days ago
Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/20918
Updated by Gerrit Code Review 2 days ago
Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/20920
Updated by Alexander Opitz 2 days ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 4b47cdf94de796ebbd8d2012136ee58e7ab57750.
Updated by Gerrit Code Review 2 days ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/20921
Updated by Gerrit Code Review 2 days ago
Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/20922
Updated by Philipp Gampe 2 days ago
- Status changed from Under Review to Resolved
Applied in changeset 156acf2784c8e73e7d6c00fb43483810538e5257.