Project

General

Profile

Actions

Bug #18665

closed

The child pages of Mount points (do not substitute mount point) are not linked correctly in menus

Added by Slite about 16 years ago. Updated over 15 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2008-04-22
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.2
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If you have a mount point that doesn't have "substitute mount point" set, the links to the child pages are missing the final parameter.

This is because the menu code passed only the required parameter -- the current page ID. In theory this means that the other parameters are calculated. Specifically, the first page ID for the mount point is retrieved from the pageRec and the pageRec is loaded from the database. However, there is a cache of the data which is used to avoid further lookups. The key for this is the current page and the first page ID of the mount point. If the first page ID wasn't passed in it is blindly extracted from the pageRec but there has been no check to see if pageRec exists -- this check occurs after the cache lookup.

The first page ID is only set/checked this once and is then appended to the MP Vars.

Net result: If the first page ID isn't passed in AND the pageRec isn't passed in then the MP Vars is missing the final parameter and the Mount Point link is broken.

The patch moves the check for pageRec's existence to before the assignment of the first page of the mount point.

(issue imported from #M8194)


Files

mp-sub-pages.diff (1.88 KB) mp-sub-pages.diff Administrator Admin, 2008-04-22 12:15
bug_8194_mp-sub-pages-v2.diff (1.48 KB) bug_8194_mp-sub-pages-v2.diff Administrator Admin, 2008-08-11 00:19

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Feature #17726: Speed up link rendering by implementing some local cachesClosedMartin Kutschker2007-10-26

Actions
Actions #1

Updated by Olivier Schopfer almost 16 years ago

The problem is still there with TYPO3 4.2.1.
(And the patch still does its job!)

Actions #2

Updated by Steffen Gebert almost 16 years ago

I can confirm this. Patch does it's job at first sight.

Actions #3

Updated by Nico Thomaier almost 16 years ago

I Patched my TYPO3 4.2.1 and the Patch seams to work.

Actions #4

Updated by gregory almost 16 years ago

I had a problem with MP Getvar not taken into account in HMENU when using the special type "list"

Patched my 4.2.1 and it solved this problem as well, therefore i hope it will be integrated soon.

Actions #5

Updated by Helmut Hummel almost 16 years ago

Well, this patch helps, but still does not do the complete job! I still miss the menu entry of the mount page itself (if substitute mout point is not set)

Actions #6

Updated by Helmut Hummel almost 16 years ago

I uploaded the patch Masi seemed to forget to commit, when implementig the caching feature. Unfortunatly the problem (with the mount page not beeing displayed in menu) described above still persists...

Actions #7

Updated by Helmut Hummel over 15 years ago

With the patch masi commited to 4_2 branch and trunk, the problem has been fixed

Actions #8

Updated by Dmitry Dulepov over 15 years ago

The problem still exists in TYPO3 4.2.3. The patch in this bug report was never committed. Links in menu look like:

http://example.com/index.php?id=12493&MP=121-

Actions #9

Updated by Dmitry Dulepov over 15 years ago

Forget it, the patch is there and similar problem was caused by another thing. All is fine with this bug :)

Actions

Also available in: Atom PDF