Bug #28564: Language overlay for RECORDS - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #28564

closed

Language overlay for RECORDS

Added by Daniela Maul almost 13 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

TypoScript

Target version:

6.0.0

Start date:

2011-07-29

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

4.5

PHP Version:

Tags:

Complexity:

medium

Is Regression:

Sprint Focus:

Description

There is no language overlay in RECORDS for pages.
It always shows the default language if I for example select the page title and switch language.

In CONTENT (class tslib_content_Content) this is solved by:

// Language overlay:
if (is_array($row) && $GLOBALS['TSFE']->sys_language_contentOL) {
    if ($conf['table'] == 'pages') {
        $row = $GLOBALS['TSFE']->sys_page->getPageOverlay($row);
    } else {
        $row = $GLOBALS['TSFE']->sys_page->getRecordOverlay($conf['table'], $row, $GLOBALS['TSFE']->sys_language_content, $GLOBALS['TSFE']->sys_language_contentOL);
    }
}

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Andreas Wolf over 12 years ago

Category set to TypoScript
Complexity set to medium

Actions

Copy link

Updated by Gerrit Code Review about 12 years ago

Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10551

Actions

Copy link

Updated by Gerrit Code Review about 12 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10551

Actions

Copy link

Updated by Gerrit Code Review about 12 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10551

Actions

Copy link

Updated by Gerrit Code Review about 12 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10551

Actions

Copy link

Updated by Thorsten Kahler about 12 years ago

Priority changed from Must have to Should have
Target version set to 6.0.0
% Done changed from 0 to 50

Fixing this bug introduces a breaking change so it should only be applied to master

Actions

Copy link

Updated by Markus Klein about 12 years ago

Hi!

Follow-up to the discussion in gerrit:

I agree with Georg that there should be an option to make default language inclusion possible, but IMHO this doesn't go far enough.
I propose to introduce a possibility where one can choose which language version he wants to include.

Use case:
id 0 = de
id 1 = en
id 2 = fr

For id 2 one might want to "fallback"/include the pages in the English version rather than German.

Actions

Copy link