Project

General

Profile

Actions

Bug #34557

closed

Missing backticks in t3lib_install_Sql->getUpdateSuggestions

Added by Nico de Haen about 12 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
-
Start date:
2012-03-06
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.7
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

Is there any reason not to add backticks in the field definitions? If I try to add a column named "order" or any other reserved word it won't work without backticks.

The attached patch adds backticks to all field and table names in this method, except in the ADD KEY field list like in:

ALTER TABLE `sys_log` ADD KEY user_auth (type,action,tstamp);


Files

t3lib_install_sql-backtick.patch (5.63 KB) t3lib_install_sql-backtick.patch Nico de Haen, 2012-03-06 12:35

Related issues 1 (0 open1 closed)

Is duplicate of TYPO3 Core - Bug #35253: Installer should respect backticks while creating sql queriesRejected2012-03-26

Actions
Actions #1

Updated by Christian Jul Jensen about 12 years ago

Thanks for providing the patch, would be great if you can submit it for review. Check out the guides here: http://typo3.org/development/bug-fixing/resolving-bugs/

Actions #2

Updated by Nico de Haen about 12 years ago

Ok, I will submit it to gerrit if you think it's a useful patch.

Actions #3

Updated by Gerrit Code Review about 12 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9551

Actions #4

Updated by Alexander Opitz almost 11 years ago

  • Status changed from Under Review to Closed

In favor of #35253

Actions

Also available in: Atom PDF