Missing backticks in t3lib_install_Sql->getUpdateSuggestions
|Status:||Under Review||Start date:||2012-03-06|
|Priority:||Should have||Due date:|
Is there any reason not to add backticks in the field definitions? If I try to add a column named "order" or any other reserved word it won't work without backticks.
The attached patch adds backticks to all field and table names in this method, except in the ADD KEY field list like in:
ALTER TABLE `sys_log` ADD KEY user_auth (type,action,tstamp);
|related to Extension Builder - Bug #37426: Invalid SQL creation with reserved words||Rejected||2012-05-23|
Updated by Christian Jul Jensen about 1 year ago
Thanks for providing the patch, would be great if you can submit it for review. Check out the guides here: http://typo3.org/development/bug-fixing/resolving-bugs/
Updated by Nico de Haen about 1 year ago
Ok, I will submit it to gerrit if you think it's a useful patch.