Bug #36296

New task button missing after deleting task

Added by Alexander Jahn about 1 year ago. Updated 9 months ago.

Status:Resolved Start date:2012-04-18
Priority:Should have Due date:
Assignee:Christian Kuhn % Done:

100%
Category:-
Target version:Core - 6.0.0
Votes: 0

Description

If a task is deleted the following window does not show the button to add a new task.

This is caused by function getDocHeaderButtons() in tx_scheduler_Module line 1568:

if (empty($this->CMD) || $this->CMD == 'list') {

Headerbuttons are only rendered if no command was issued or if the command is 'list'.

I suggest adding command 'delete' to the list so the buttons shows up again after deleting a task.

I found this in both TYPO3 4.6.8 and TYPO3 4.7.0rc2

missing_button.JPG - Missing "Add Task" button after deleting task (32.6 kB) Alexander Jahn, 2012-04-18 14:59

class.tx_scheduler_module.php_4-6-8.patch - Patch for scheduler in TYPO3 4.6.8 (634 Bytes) Alexander Jahn, 2012-04-18 14:59

class.tx_scheduler_module.php_4-7-0.patch - Patch for scheduler in TYPO3 4.7.0 (634 Bytes) Alexander Jahn, 2012-04-18 14:59

Related issues

related to Scheduler - Bug #36923: After deleting task, "New Task" button disappears Closed 2012-05-07

Associated revisions

Revision 18fdca0e
Added by Alexander Jahn about 1 year ago

[BUGFIX] New task button missing after deleting task

Change-Id: I7b0dd0ef83d8fe62aeaf12849bcf87b00801eacc
Fixes: #36296
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/10700
Reviewed-by: Philipp Gampe
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Revision 0e409018
Added by Alexander Jahn about 1 year ago

[BUGFIX] New task button missing after deleting task

Change-Id: I7b0dd0ef83d8fe62aeaf12849bcf87b00801eacc
Fixes: #36296
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/10851
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Revision 1db371c4
Added by Alexander Jahn about 1 year ago

[BUGFIX] New task button missing after deleting task

Change-Id: I7b0dd0ef83d8fe62aeaf12849bcf87b00801eacc
Fixes: #36296
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/10852
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Revision e85c726b
Added by Alexander Jahn about 1 year ago

[BUGFIX] New task button missing after deleting task

Change-Id: I7b0dd0ef83d8fe62aeaf12849bcf87b00801eacc
Fixes: #36296
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/10700
Reviewed-by: Philipp Gampe
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

History

#1
Updated by Felix Kopp about 1 year ago

I can reproduce this.
Thank you very much for the patch - would you like to push the patchset to gerrit (the review server)?

Here you can find the Walkthrough that explains how to get your patchset into the core:
http://wiki.typo3.org/Contribution_Walkthrough

#2
Updated by Francois Suter about 1 year ago

  • Target version deleted (4.7.0)

#3
Updated by Alexander Jahn about 1 year ago

I'd really like to push my patch to gerrit but port 29418 is blocked in my company's firewall. This won't change.

Could you do that for me, please?

#4
Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10700

#5
Updated by Julian Hofmann about 1 year ago

I can reproduce this in LTS version (4.5), too.

#6
Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/10851

#7
Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/10852

#8
Updated by Alexander Jahn about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Applied in changeset commit:1db371c44ab6642420b01ea96bfbb603ace93531.

#9
Updated by Francois Suter 10 months ago

  • Assignee set to Christian Kuhn
  • Target version set to 6.0.0

#10
Updated by Gerrit Code Review 10 months ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/13122

#11
Updated by Gerrit Code Review 10 months ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/13244

#12
Updated by Christian Kuhn 9 months ago

  • Status changed from Under Review to Resolved

Merged in all relevant versions.

Also available in: Atom PDF